add cxx abi flag to setup.py #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
Tested by running ` pip install -e . --install-option="--abicxx"` on a manually built version of pytorch. We'd likely have to use a pytorch docker image if we want to do unit tests for this. [ghstack-poisoned]
Contributor
Author
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Tested by running ` pip install -e . --install-option="--abicxx"` on a manually built version of pytorch. We'd likely have to use a pytorch docker image if we want to do unit tests for this. Differential Revision: [D40450067](https://our.internmc.facebook.com/intern/diff/D40450067) [ghstack-poisoned]
Contributor
Author
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Tested by running
pip install -e . --install-option="--abicxx"on a manually built version of pytorch. We'd likely have to use a pytorch docker image if we want to do unit tests for this.Differential Revision: D40450067