Skip to content

add cxx abi flag to setup.py #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PaliC wants to merge 3 commits into from
Closed

add cxx abi flag to setup.py #204

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93e516f
add cxx abi flag to setup.py
PaliC Oct 10, 2022
99552c8
Update on "add cxx abi flag to setup.py"
PaliC Oct 17, 2022
370bffe
Update on "add cxx abi flag to setup.py"
PaliC Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def get_cmake_version():


class MultipyRuntimeCmake(object):
user_options = [("cmakeoff", None, None)]
user_options = [("cmakeoff", None, None), ("abicxx", None, None)]


class MultipyRuntimeDevelop(MultipyRuntimeCmake, develop):
Expand All @@ -37,16 +37,20 @@ class MultipyRuntimeDevelop(MultipyRuntimeCmake, develop):
def initialize_options(self):
develop.initialize_options(self)
self.cmakeoff = None
self.abicxx = None

def finalize_options(self):
develop.finalize_options(self)
if self.cmakeoff is not None:
self.distribution.get_command_obj("build_ext").cmake_off = True
if self.abicxx is not None:
self.distribution.get_command_obj("build_ext").abicxx = True


class MultipyRuntimeBuild(MultipyRuntimeCmake, build_ext):
user_options = build_ext.user_options + MultipyRuntimeCmake.user_options
cmake_off = False
abicxx = False

def run(self):
if self.cmake_off:
Expand All @@ -67,11 +71,14 @@ def run(self):
if not os.path.exists(build_dir_abs):
os.makedirs(build_dir_abs)
legacy_python_cmake_flag = "OFF" if sys.version_info.minor > 7 else "ON"
cxx_abi_flag = "ON" if self.abicxx else "OFF"

print(f"-- Running multipy runtime makefile in dir {build_dir_abs}")
try:
subprocess.run(
[f"cmake -DLEGACY_PYTHON_PRE_3_8={legacy_python_cmake_flag} .."],
[
f"cmake -DLEGACY_PYTHON_PRE_3_8={legacy_python_cmake_flag} -DABI_EQUALS_1={cxx_abi_flag} .."
],
cwd=build_dir_abs,
shell=True,
check=True,
Expand Down