BB-718 CritiqueBrainz auth endpoint is called server-side #1041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BB-718: CritiqueBrainz auth endpoint is called server-side
Solution
The conditional check -
typeof window !== "undefined"
ensures that thegetAccessToken
method is only called when the code is executed in a browser environment (client-side), preventing the unnecessary call to the authentication endpoint on the server-side.Areas of Impact
The changes were reflected in
src/client/components/pages/entities/cbReviewModal.tsx