Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-718 CritiqueBrainz auth endpoint is called server-side #1041

Merged
merged 2 commits into from
Jan 12, 2024
Merged

BB-718 CritiqueBrainz auth endpoint is called server-side #1041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c71c573
auth endpoint fixed on client side
kirtanchandak Dec 18, 2023
f67c6ae
comment added
kirtanchandak Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/client/components/pages/entities/cbReviewModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,11 @@ class CBReviewModal extends React.Component<

private accessToken = '';

/* executes getAccessToken() only in a browser to avoid unnecessary server-side calls during component mounting */
componentDidMount = async () => {
this.accessToken = await this.getAccessToken();
if (typeof window !== "undefined") {
this.accessToken = await this.getAccessToken();
}
};

render() {
Expand Down
Loading