Fix(AC): Fix author credit link #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it work for both the edit page when adding a new author credit as well as on the entity display pages.
tr1ten
approved these changes
Aug 5, 2022
MonkeyDo
added a commit
that referenced
this pull request
Aug 23, 2022
Made a rookie mistake in #868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two different situations for Author Credits display component: one is on the edit page when adding a new AC and the other is on the entity display pages displaying an existing AC.
Depending on which case we are looking at, the author used to construct the AC will not have the same shape, and the author BBID in particular will not be in the same place.
This results currently on broken AC links (href =
/author/undefined) on the entity display pages (but working for edit pages).