Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types for parameter location/style, paths, and schemas #20

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Apr 19, 2018

This PR further aligns TS types with open api spec terms

  • Add ParameterLocation and ParameterStyle to enumerate the possible string values.
  • Rename PathObject to PathsObject
  • Add SchemasObject

- Rename PathObject to PathsObject
- Add SchemasObject
@raymondfeng raymondfeng changed the title Add types for ParameterLocation and ParameterStyle Improve types for parameter location/style, paths, and schemas Apr 19, 2018
@raymondfeng
Copy link
Contributor Author

raymondfeng commented Apr 20, 2018

@pjmolina Any chance to review the PR?

@pjmolina
Copy link
Contributor

Hi @raymondfeng Thanks for contribution.
Yes! I am going to review it in minutes.

@pjmolina pjmolina merged commit 1861297 into metadevpro:master Apr 20, 2018
@pjmolina
Copy link
Contributor

Merged. Thanks @raymondfeng
I am publishing now a new npm package with your changes.

@raymondfeng
Copy link
Contributor Author

@pjmolina Thanks for the prompt response!

@pjmolina
Copy link
Contributor

pjmolina commented Apr 20, 2018

Can you check this error ? @raymondfeng

Seems that typing the ParameterLocation breaks the tests with ts-node 6.0 but worked with ts-node 5.0

@raymondfeng
Copy link
Contributor Author

@pjmolina See #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants