New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast "header" to ParameterLocation to avoid ts-node 6.x error #21

Merged

pjmolina merged 1 commit into metadevpro:master from raymondfeng:master

Apr 20, 2018

Contributor

raymondfeng commented Apr 20, 2018

This is really weird. I see the following error from inside VSCode:

Argument of type '{ name: string; in: string; schema: { $ref: string; }; }' is not assignable to parameter of type 'ParameterObject'.
  Types of property 'in' are incompatible.
    Type 'string' is not assignable to type 'ParameterLocation'.

But TypeScript claims it's fixed by microsoft/TypeScript#10676


          Cast "header" to ParameterLocation to avoid ts-node 6.x error

3bf2273

pjmolina merged commit 33c1644 into metadevpro:master

raymondfeng mentioned this pull request

Improve types for parameter location/style, paths, and schemas #20

Merged

Contributor

pjmolina commented Apr 20, 2018

Thanks!

Yes. That the point!
We avoided literal types till your PR for such reason. It were causing problems like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet