Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slf4j-log4j12 should not be a runtime dependency #130

Closed
cboehme opened this issue Aug 8, 2013 · 1 comment
Closed

slf4j-log4j12 should not be a runtime dependency #130

cboehme opened this issue Aug 8, 2013 · 1 comment
Assignees
Labels
Milestone

Comments

@cboehme
Copy link
Member

cboehme commented Aug 8, 2013

the slf4j implementation is something that the user has to provide. It should not be defined in the pom. It should probably be included as a test dependency only similar to simple-jndi.

For the assembly a way needs to be found to include both log4j and simple-jndi in the distribution, so that the user does not have to bother with choosing implementations for either service.

@cboehme
Copy link
Member Author

cboehme commented Mar 1, 2014

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant