Remove code for runner #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both dependencies should be provided by the user of metafacture because the concret implementation depends on the environment.
The metafacture command line application is now part of the new metafacture-runner package. Consequently, it has been removed from the core package along with all its auxiliary files and the assembly target has been removed from the pom. By managing the end user applications for metafacture in a separate project dependencies on logger implementations, database driver etc. can be more easily managed. It also helps to keep the build configuration of the core package reasonably simple.
|
Merged |
blackwinter
pushed a commit
that referenced
this pull request
Dec 13, 2024
blackwinter
pushed a commit
that referenced
this pull request
Dec 13, 2024
Fix issue with testing non-existing refs, update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all code and configuration from metafacture-core which is only used by the command line application. This application is now distriibuted in the separate package culturegraph/metafacture-runner.
The commits in this request fix #130, #131 and additionally #168.