Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples and annotations on Flux command implementations #92

Merged
merged 1 commit into from
Jun 14, 2013

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Jun 13, 2013

With the Flux validator in the Metafacture IDE, the @In and @Out
annotations on the Flux command implementation classes are processed
to check the workflows (see [1]). With the current Flux examples in
metafacture-core, the IDE reports some errors and warnings which
this commit fixes:

  • Update morph-marc21.flux to use the new encode-literals command
  • Fix @In and @Out annotations of TripleCount
  • Add some missing @In, @Out, and @Description annotations

[1] culturegraph/metafacture-ide#23

With the Flux validator in the Metafacture IDE, the `@In` and `@Out`
annotations on the Flux command implementation classes are processed
to check the workflows (see [1]). With the current Flux examples in
metafacture-core, the IDE reports some errors and warnings which
this commit fixes:

- Update morph-marc21.flux to use the new `encode-literals` command
- Fix `@In` and `@Out` annotations of `TripleCount`
- Add some missing `@In`, `@Out`, and `@Description` annotations

[1] culturegraph/metafacture-ide#23
cboehme added a commit that referenced this pull request Jun 14, 2013
Fix examples and annotations on Flux command implementations
@cboehme cboehme merged commit 2628b6c into metafacture:master Jun 14, 2013
@cboehme
Copy link
Member

cboehme commented Jun 14, 2013

Thank you for these additions.

blackwinter pushed a commit that referenced this pull request Dec 13, 2024
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
Replace replace*/append* methods with insert* and InsertMode usage

Use get / set / add / remove methods on Record for interaction
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
blackwinter pushed a commit that referenced this pull request Dec 13, 2024
Fix issue with testing non-existing refs, update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants