Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot parse multi-line pica records with 1.2.0 (MissingIdException) #155

Closed
dmj opened this issue Dec 5, 2013 · 2 comments
Closed

Cannot parse multi-line pica records with 1.2.0 (MissingIdException) #155

dmj opened this issue Dec 5, 2013 · 2 comments
Assignees
Milestone

Comments

@dmj
Copy link

dmj commented Dec 5, 2013

PicaDecoder in 1.2.0 uses a regular expression to find the record id. The expression is defined as:

"003@ " + 0x1F + "0(.*)?" + 0x1E

By default "." does not match the newline character (cf. http://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html#DOTALL), thus the regexp fails if a multi-line record like the one in https://gist.github.com/dmj/7116314 is used.

@ghost ghost assigned cboehme Dec 5, 2013
@cboehme
Copy link
Member

cboehme commented Dec 5, 2013

Version 1.2.0 still uses the old regex-based PicaDecoder which was not designed to handle multi-line pica records. The new PicaDecoder is not included in this minor release because it behaves differently from the old version in some situations. The new decoder is already merged into master and will be part of the next major release. Sorry about that.

@dmj
Copy link
Author

dmj commented Dec 8, 2013

Thanks. Wasn't sure if `as-records' is supposed to work with multi-line pica records or not. Turns out it isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants