Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metamorph verify no more interactions. #340

Closed
wants to merge 2 commits into from
Closed

Metamorph verify no more interactions. #340

wants to merge 2 commits into from

Conversation

blackwinter
Copy link
Member

Resolves #339.

@blackwinter
Metamorph basics test should verify that no unexpected interactions o…
163823b 
…ccurred in order.

* Added debug output for assertion errors.
* Silenced `MockitoHint`s in `LookupTest` (due to showing standard streams).
* Added `startEntity`/`endEntity` events where they were previously unverified.
* Didn't enable check for unverified interactions yet; `shouldHandleUnmatchedLiteralsAndEntitiesInElseNestedSource` doesn't pass.
* Removed redundant (?) `any()` literal verifications in `shouldMatchCharacterWithQuestionMarkWildcard` and `shouldMatchCharactersInCharacterClass`.
@blackwinter
Metamorph basics test should verify that no unexpected interactions o…
bc2e29f 
…ccurred at all.

* Changed `shouldHandleUnmatchedLiteralsAndEntitiesInElseNestedSource` to match actual behaviour (see #338).
@blackwinter blackwinter requested a review from dr0i November 2, 2020 10:11
@blackwinter blackwinter self-assigned this Nov 2, 2020
@blackwinter blackwinter mentioned this pull request Nov 2, 2020
Closed
@blackwinter
Copy link
Member Author

Re-created as #341 with different source branch.

Apparently, branch names must be valid file names since they're part of the project version.

Could not determine the dependencies of task ':metafacture-runner:distTar'.
> path may not be null or empty string. path='null'

@blackwinter blackwinter closed this Nov 2, 2020
@blackwinter blackwinter deleted the issue/339-metamorph-verify-no-more-interactions branch December 8, 2020 08:31
blackwinter added a commit that referenced this pull request Dec 13, 2024
@blackwinter
Merge pull request #340 from metafacture/closeResources
eebbe88 
Close resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0i dr0i Awaiting requested review from dr0i

Assignees

@blackwinter blackwinter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metamorph tests should verify that no unexpected interactions occurred
1 participant
@blackwinter