Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metamorph tests should verify that no unexpected interactions occurred #339

Closed
blackwinter opened this issue Oct 29, 2020 · 3 comments · Fixed by #341 or #413
Closed

Metamorph tests should verify that no unexpected interactions occurred #339

blackwinter opened this issue Oct 29, 2020 · 3 comments · Fixed by #341 or #413
Assignees
@blackwinter

Comments

@blackwinter
Copy link
Member

blackwinter commented Oct 29, 2020 •
edited
Loading

When verifying Metamorph streams, unexpected events may go unnoticed without Mockito.verifyNoMoreInteractions() (and InOrder.verifyNoMoreInteractions()).

The author's "warning" doesn't apply here, IMHO, since we actually do want to check the resulting data structure (i.e., event stream) as a whole.

Originally posted by @blackwinter in #338 (comment)
@blackwinter blackwinter changed the title Tests should verify that no unexpected interactions occurred Metamorph tests should verify that no unexpected interactions occurred Oct 29, 2020
@blackwinter blackwinter mentioned this issue Nov 2, 2020
Closed
@blackwinter
Copy link
Member Author

blackwinter commented Nov 2, 2020 •
edited
Loading

Would something along the lines of PR #341 be acceptable?

@blackwinter blackwinter mentioned this issue Nov 2, 2020
Merged
@blackwinter
Copy link
Member Author

Not all Metamorph tests fixed yet.

@blackwinter blackwinter reopened this Nov 2, 2020
@blackwinter blackwinter self-assigned this Nov 3, 2020
@blackwinter
Copy link
Member Author

blackwinter commented Sep 23, 2021 •
edited
Loading

Progress: ✔️

  • Metamorph tests verify that no unexpected interactions occurred (first batch). #341:
    • TestMetamorphBasics.java
    • TestMetamorphMacros.java
    • collectors/TuplesTest.java
    • functions/UniqueTest.java
    • maps/FileMapTest.java
    • maps/JavaMapTest.java
  • Metamorph tests verify that no unexpected interactions occurred (second and final batch). #413:
    • MetamorphTest.java
    • SplitterTest.java
    • collectors/AllTest.java
    • collectors/AnyTest.java
    • collectors/ChooseTest.java
    • collectors/CombineTest.java
    • collectors/ConcatTest.java
    • collectors/EntityTest.java
    • collectors/EqualsFilterTest.java
    • collectors/GroupTest.java
    • collectors/NoneTest.java
    • collectors/RangeTest.java
    • collectors/SquareTest.java
    • collectors/TestCollectorBasics.java
    • collectors/TestCollectorIf.java
    • functions/DateFormatTest.java
    • functions/LookupTest.java
    • functions/RegexpTest.java
    • functions/ScriptTest.java
    • functions/SplitTest.java
    • functions/SwitchNameValueTest.java
    • functions/TestFunctionBasics.java
    • functions/TestVariousFunctions.java
  • Not applicable (no stream tests):
    • functions/ISBNTest.java
    • functions/NormalizeUTF8Test.java
    • functions/StringOperationsTest.java
    • xml/DomLoaderTest.java

@blackwinter blackwinter mentioned this issue Oct 9, 2021
Open
@blackwinter blackwinter mentioned this issue Oct 30, 2021
Merged
blackwinter added a commit that referenced this issue Dec 13, 2024
@blackwinter
Change link text for playground examples. (#339)
a22c122 
To be more in line with Flux commands; see #509.
blackwinter added a commit that referenced this issue Dec 13, 2024
@blackwinter
Fix typo in example link. (#339)
49e9a4e
blackwinter added a commit that referenced this issue Dec 13, 2024
@blackwinter
Fix example links. (#339)
ec0b2fe 
Now that metafacture/metafacture-playground#153 has been resolved.
blackwinter added a commit that referenced this issue Dec 13, 2024
@blackwinter
Merge pull request #339 from metafacture/add_links_to_playground
6250389 
Add links to  playground for several fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackwinter blackwinter

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@blackwinter