🌱 Add dev-env-integration tests to prow #678

peppi-lotta · 2024-03-26T13:24:40Z

Added some tests to be run from PRs in BMO, CAPM3, metal-dev-env, project-infra and, IPAM. Also changed some values to work with Prow.

tuminoid

/approve

Sunnatillo

We should also add checkout logic for PR tests like this.

    if [[ -n "${PR_ID:-}" ]]; then
        git fetch origin "pull/${PR_ID}/head:${UPDATED_BRANCH}-branch" || true
    fi

Lets discuss it with @mboukhalfa.

Sunnatillo · 2024-03-28T10:45:47Z

jenkins/jobs/dev_env_integration_tests.pipeline

-    UPDATED_BRANCH = "${ghprbActualCommit}"
+    REPO_ORG = "${env.REPO_OWNER}"
+    REPO_NAME = "${env.REPO_NAME}"
+    REPO_BRANCH = "${env.PULL_BASE_REF}"


This varibale needed to run for PR tests. Please add it here and jjb PR as well
PR_ID = "${env.PULL_NUMBER}"

Sunnatillo · 2024-03-28T10:49:31Z

jenkins/scripts/dynamic_worker_workflow/dev_env_integration_tests.sh

@@ -12,6 +12,8 @@ CI_DIR="$(dirname "$(readlink -f "${0}")")"
 export IMAGE_OS="${IMAGE_OS:-ubuntu}"
 export REPO_ORG="${REPO_ORG:-metal3-io}"
 export REPO_NAME="${REPO_NAME:-metal3-dev-env}"
+export REPO_BRANCH="${REPO_BRANCH:-main}"
+export PR_ID="${PR_ID:-0}"


Suggested change

export PR_ID="${PR_ID:-0}"

export PR_ID="${PR_ID:-}"

Sunnatillo · 2024-03-28T10:55:28Z

prow/manifests/overlays/metal3/config.yaml

@@ -1334,6 +1400,39 @@ presubmits:
      agent: jenkins
      always_run: false
      optional: true
+    # name: {job_prefix}-{image_os}-dev-env-integration-test-{capm3_target_branch}


same here, lets not add tests for community repo as well

Sunnatillo · 2024-03-28T10:55:53Z

prow/manifests/overlays/metal3/config.yaml

@@ -1843,6 +1975,39 @@ presubmits:
      agent: jenkins
      always_run: false
      optional: true
+    # name: {job_prefix}-{image_os}-dev-env-integration-test-{capm3_target_branch}


Lets not add tests for metal3-io/metal3-docs repo and

I think the preview cuts the code in a poorly informative way. The test are actually under metal3-io/baremetal-operater, metal3-io/cluster-api-provider-metal3, metal3-io/meta3-dev-env, metal3-io/project-infra and metal3-io/ip-address-manager.

I checked that these are the projects where integration tests are run. Are these all correct and/or am I missing some still?

Sunnatillo

/lgtm
/hold
lets wait tojjb PR merge and we can test it here

smoshiur1237

lgtm

metal3-io-bot · 2024-04-15T09:19:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mboukhalfa · 2024-04-15T10:40:15Z

jenkins/scripts/dynamic_worker_workflow/dev_env_integration_tests.sh

In case we run the test on PR open on metal3-io org from nordix branch:
in line 52 when we clone the repo https://github.com/${REPO_ORG}/${REPO_NAME}.git this should clone the metal3-io repo how do we merge the nordix branch changes that we want to test

any suggestions?

refspec is added to solve the issue

Sunnatillo · 2024-04-17T11:47:17Z

/test dev-env-integration-test-ubuntu-main

metal3-io-bot · 2024-04-17T11:47:20Z

@Sunnatillo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test check-prow-config
/test markdownlint
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/test shellcheck

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-main
/test metal3-centos-e2e-basic-test-release-1-6
/test metal3-centos-e2e-feature-test-main
/test metal3-centos-e2e-feature-test-release-1-4
/test metal3-centos-e2e-feature-test-release-1-5
/test metal3-centos-e2e-feature-test-release-1-6
/test metal3-centos-e2e-integration-test-release-1-4
/test metal3-centos-e2e-integration-test-release-1-5
/test metal3-centos-e2e-integration-test-release-1-6
/test metal3-e2e-1-26-1-27-upgrade-test-main
/test metal3-e2e-1-26-1-27-upgrade-test-release-1-4
/test metal3-e2e-1-26-1-27-upgrade-test-release-1-5
/test metal3-e2e-1-26-1-27-upgrade-test-release-1-6
/test metal3-e2e-1-27-1-28-upgrade-test-main
/test metal3-e2e-1-27-1-28-upgrade-test-release-1-4
/test metal3-e2e-1-27-1-28-upgrade-test-release-1-5
/test metal3-e2e-1-27-1-28-upgrade-test-release-1-6
/test metal3-e2e-1-28-1-29-upgrade-test-main
/test metal3-e2e-1-28-1-29-upgrade-test-release-1-4
/test metal3-e2e-1-28-1-29-upgrade-test-release-1-5
/test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
/test metal3-e2e-clusterctl-upgrade-test-main
/test metal3-e2e-clusterctl-upgrade-test-release-0-5
/test metal3-e2e-clusterctl-upgrade-test-release-1-3
/test metal3-e2e-clusterctl-upgrade-test-release-1-4
/test metal3-e2e-clusterctl-upgrade-test-release-1-5
/test metal3-e2e-clusterctl-upgrade-test-release-1-6
/test metal3-keep-e2e-1-26-1-27-upgrade-test-main
/test metal3-keep-e2e-1-26-1-27-upgrade-test-release-1-4
/test metal3-keep-e2e-1-26-1-27-upgrade-test-release-1-5
/test metal3-keep-e2e-1-26-1-27-upgrade-test-release-1-6
/test metal3-keep-e2e-1-27-1-28-upgrade-test-main
/test metal3-keep-e2e-1-27-1-28-upgrade-test-release-1-4
/test metal3-keep-e2e-1-27-1-28-upgrade-test-release-1-5
/test metal3-keep-e2e-1-27-1-28-upgrade-test-release-1-6
/test metal3-keep-e2e-1-28-1-29-upgrade-test-main
/test metal3-keep-e2e-1-28-1-29-upgrade-test-release-1-4
/test metal3-keep-e2e-1-28-1-29-upgrade-test-release-1-5
/test metal3-keep-e2e-1-28-1-29-upgrade-test-release-1-6
/test metal3-keep-e2e-clusterctl-upgrade-test-main
/test metal3-keep-e2e-clusterctl-upgrade-test-release-0-5
/test metal3-keep-e2e-clusterctl-upgrade-test-release-1-3
/test metal3-keep-e2e-clusterctl-upgrade-test-release-1-4
/test metal3-keep-e2e-clusterctl-upgrade-test-release-1-5
/test metal3-keep-e2e-clusterctl-upgrade-test-release-1-6
/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-basic-test-release-1-6
/test metal3-ubuntu-e2e-feature-test-main
/test metal3-ubuntu-e2e-feature-test-release-1-4
/test metal3-ubuntu-e2e-feature-test-release-1-5
/test metal3-ubuntu-e2e-feature-test-release-1-6
/test metal3-ubuntu-e2e-integration-test-release-1-4
/test metal3-ubuntu-e2e-integration-test-release-1-5
/test metal3-ubuntu-e2e-integration-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

check-prow-config
shellcheck

In response to this:

/test dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Peppi-Lotta <peppi-lotta.saari@est.tech>

Sunnatillo

/lgtm

Sunnatillo · 2024-04-18T11:02:30Z

/override test-ubuntu-integration-main

metal3-io-bot · 2024-04-18T11:02:33Z

@Sunnatillo: Sunnatillo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sunnatillo · 2024-04-18T11:07:50Z

I will unhold this PR since it is not possible to test new test before merging this PR, and this test needed to tests new cloud.
Issues will be tackled in a followup PR if any.

Sunnatillo · 2024-04-18T11:07:57Z

/unhold

tuminoid · 2024-04-18T11:14:35Z

/override test-ubuntu-integration-main

metal3-io-bot · 2024-04-18T11:14:38Z

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

metal3-io-bot · 2024-04-18T11:15:29Z

@peppi-lotta: Updated the config configmap in namespace prow at cluster default using the following files:

key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Added some tests to be run from PRs in BMO, CAPM3, metal-dev-env, project-infra and, IPAM. Also changed some values to work with Prow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sunnatillo · 2024-04-18T13:28:46Z

part of #705

metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024

tuminoid reviewed Mar 28, 2024

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024

Sunnatillo reviewed Mar 28, 2024

View reviewed changes

metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024

peppi-lotta force-pushed the peppi/dev-env-integration-tests-to-prow branch from ed0e92e to 9299ed2 Compare April 8, 2024 09:06

metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2024

peppi-lotta force-pushed the peppi/dev-env-integration-tests-to-prow branch from 9299ed2 to 66cd96f Compare April 8, 2024 09:20

metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 8, 2024

peppi-lotta force-pushed the peppi/dev-env-integration-tests-to-prow branch from 66cd96f to 7b97d14 Compare April 8, 2024 09:26

metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024

Sunnatillo reviewed Apr 8, 2024

View reviewed changes

metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 8, 2024

smoshiur1237 approved these changes Apr 15, 2024

View reviewed changes

mboukhalfa reviewed Apr 15, 2024

View reviewed changes

Add dev-env-integration test to prow

cd95990

Signed-off-by: Peppi-Lotta <peppi-lotta.saari@est.tech>

peppi-lotta force-pushed the peppi/dev-env-integration-tests-to-prow branch from 7b97d14 to cd95990 Compare April 18, 2024 10:58

metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024

Sunnatillo reviewed Apr 18, 2024

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024

metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024

metal3-io-bot merged commit 8e6d943 into metal3-io:main Apr 18, 2024
6 checks passed

Sunnatillo deleted the peppi/dev-env-integration-tests-to-prow branch April 18, 2024 11:18

peppi-lotta mentioned this pull request Apr 23, 2024

Migration to prow jenkins operator #702

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 Add dev-env-integration tests to prow #678

🌱 Add dev-env-integration tests to prow #678

peppi-lotta commented Mar 26, 2024

tuminoid left a comment

Sunnatillo left a comment

Sunnatillo Mar 28, 2024 •

edited

Loading

Sunnatillo Mar 28, 2024

Sunnatillo Mar 28, 2024

Sunnatillo Mar 28, 2024

peppi-lotta Apr 4, 2024 •

edited

Loading

Sunnatillo Apr 8, 2024

Sunnatillo left a comment

smoshiur1237 left a comment

metal3-io-bot commented Apr 15, 2024

mboukhalfa Apr 15, 2024

Sunnatillo Apr 17, 2024

Sunnatillo Apr 18, 2024

Sunnatillo commented Apr 17, 2024

metal3-io-bot commented Apr 17, 2024

Sunnatillo left a comment

Sunnatillo commented Apr 18, 2024

metal3-io-bot commented Apr 18, 2024

Sunnatillo commented Apr 18, 2024

Sunnatillo commented Apr 18, 2024

tuminoid commented Apr 18, 2024

metal3-io-bot commented Apr 18, 2024

metal3-io-bot commented Apr 18, 2024

Sunnatillo commented Apr 18, 2024 •

edited

Loading

🌱 Add dev-env-integration tests to prow #678

🌱 Add dev-env-integration tests to prow #678

Conversation

peppi-lotta commented Mar 26, 2024

tuminoid left a comment

Choose a reason for hiding this comment

Sunnatillo left a comment

Choose a reason for hiding this comment

Sunnatillo Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

Sunnatillo Mar 28, 2024

Choose a reason for hiding this comment

Sunnatillo Mar 28, 2024

Choose a reason for hiding this comment

Sunnatillo Mar 28, 2024

Choose a reason for hiding this comment

peppi-lotta Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

Sunnatillo Apr 8, 2024

Choose a reason for hiding this comment

Sunnatillo left a comment

Choose a reason for hiding this comment

smoshiur1237 left a comment

Choose a reason for hiding this comment

metal3-io-bot commented Apr 15, 2024

mboukhalfa Apr 15, 2024

Choose a reason for hiding this comment

Sunnatillo Apr 17, 2024

Choose a reason for hiding this comment

Sunnatillo Apr 18, 2024

Choose a reason for hiding this comment

Sunnatillo commented Apr 17, 2024

metal3-io-bot commented Apr 17, 2024

Sunnatillo left a comment

Choose a reason for hiding this comment

Sunnatillo commented Apr 18, 2024

metal3-io-bot commented Apr 18, 2024

Sunnatillo commented Apr 18, 2024

Sunnatillo commented Apr 18, 2024

tuminoid commented Apr 18, 2024

metal3-io-bot commented Apr 18, 2024

metal3-io-bot commented Apr 18, 2024

Sunnatillo commented Apr 18, 2024 • edited Loading

Sunnatillo Mar 28, 2024 •

edited

Loading

peppi-lotta Apr 4, 2024 •

edited

Loading

Sunnatillo commented Apr 18, 2024 •

edited

Loading