Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dynamic fullstack builder pipeline #779

Merged
merged 1 commit into from
Jun 18, 2024
Merged

implement dynamic fullstack builder pipeline #779

merged 1 commit into from
Jun 18, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Jun 5, 2024 •
edited
Loading

This commit:

  • Adds a new pipeline for running the fulstack build job on dynamic workers
  • Moves over all the fullstack related scripts from the Nordix/metal3-dev-tools repository to the metal3-io/project-infra repository
  • Is the first step in migrating and updating the fullstack pipeline

@Rozzii
implement dynamic fullstack builder pipeline
90e6a0f 
This commit:
  - Adds a new pipeline for running the fulstack build job on
    dynamic workers
  - Moves over all the fullstack related scripts from the
    Nordix/metal3-dev-tools repository to the metal3-io/project-infra
    repository
  - Is a first step in migrating and updating the fullstack pipeline

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 5, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Jun 10, 2024

/override metal3-ubuntu-e2e-integration-test-main
Not relevant.

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
Not relevant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sunnatillo
Sunnatillo approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@Sunnatillo
Copy link
Member

@kashifest @tuminoid @mboukhalfa
We need to merge this. Further improvements/fixes will be done later as we discussed in weekly.

tuminoid
tuminoid reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Plenty of things to cleanup in follow-ups for sure, let's take it in now to start that work.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@metal3-io-bot metal3-io-bot merged commit ffbf108 into metal3-io:main Jun 18, 2024
5 of 6 checks passed
@Sunnatillo Sunnatillo mentioned this pull request Sep 27, 2024
Open
3 tasks
@Sunnatillo Sunnatillo deleted the dynamic_fullstack branch November 8, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rozzii @metal3-io-bot @Sunnatillo @tuminoid