-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dracut from the IPA rootfs #943
base: main
Are you sure you want to change the base?
Conversation
this commit: - removes the dracut packages from the rootfs The size of the IPA image is slowly but steadily growing, and in order to minimize the size of the image some packages could be removed. Although dracut is used at some point in the DIB build process there is no point leaving it in the root file system after the IPA build process is finished. IPA user space does not rely on dracut, systemd can handle everything on it's own. Signed-off-by: Adam Rozman <adam.rozman@est.tech>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override metal3-ubuntu-e2e-integration-test-main Metal3 IPA is also not used in any mandatory CI pipeline so it won't cause breakage anyhow. |
@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
@@ -0,0 +1,9 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#!/bin/bash | |
#!/usr/bin/env bash |
set -x | ||
fi | ||
set -eu | ||
set -o pipefail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no pipes in this script.
@@ -0,0 +1,9 @@ | |||
#!/bin/bash | |||
|
|||
if [ "${DIB_DEBUG_TRACE:-1}" -gt 0 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [ "${DIB_DEBUG_TRACE:-1}" -gt 0 ]; then | |
if [[ "${DIB_DEBUG_TRACE:-1}" -gt 0 ]]; then |
this PR:
The size of the IPA image is slowly but steadily growing, and in order to minimize the size of the image some packages could be removed.
Although dracut is used at some point in the DIB build process there is no point leaving it in the root file system after the IPA build process is finished. IPA user space does not rely on dracut, systemd can handle everything on it's own.