Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dracut from the IPA rootfs #943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Jan 3, 2025

this PR:

  • removes the dracut packages from the rootfs

The size of the IPA image is slowly but steadily growing, and in order to minimize the size of the image some packages could be removed.

Although dracut is used at some point in the DIB build process there is no point leaving it in the root file system after the IPA build process is finished. IPA user space does not rely on dracut, systemd can handle everything on it's own.

this commit:
  - removes the dracut packages from the rootfs

The size of the IPA image is slowly but steadily growing, and in order to
minimize the size of the image some packages could be removed.

Although dracut is used at some point in the DIB build process there  is no
point leaving it in the root file system after the IPA build process is
finished. IPA user space does not rely on dracut, systemd can handle everything
on it's own.

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Jan 3, 2025

/override metal3-ubuntu-e2e-integration-test-main
This would be tested by the fullstack but fullstack is not yet compatible with prow but I have used this script to build an IPA and booted it successfully .

Metal3 IPA is also not used in any mandatory CI pipeline so it won't cause breakage anyhow.

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
This would be tested by the fullstack but fullstack is not yet compatible with prow but I have used this script to build an IPA and booted it successfully .

Metal3 IPA is also not used in any mandatory CI pipeline so it won't cause breakage anyhow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii
Copy link
Member Author

Rozzii commented Jan 3, 2025

/cc @peppi-lotta @kashifest

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

@@ -0,0 +1,9 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

set -x
fi
set -eu
set -o pipefail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no pipes in this script.

@@ -0,0 +1,9 @@
#!/bin/bash

if [ "${DIB_DEBUG_TRACE:-1}" -gt 0 ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ "${DIB_DEBUG_TRACE:-1}" -gt 0 ]; then
if [[ "${DIB_DEBUG_TRACE:-1}" -gt 0 ]]; then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants