Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): implicit MAML omniglot example #48

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

Benjamin-eecs
Copy link
Member

@Benjamin-eecs Benjamin-eecs commented Aug 3, 2022

Description

Add implicit MAML omniglot example

Motivation and Context

To test implicit differetiation API

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@Benjamin-eecs Benjamin-eecs marked this pull request as draft August 12, 2022 07:53
@Benjamin-eecs Benjamin-eecs linked an issue Sep 3, 2022 that may be closed by this pull request
7 tasks
@Benjamin-eecs Benjamin-eecs changed the title feat(examples): init implicit MAML omniglot example feat(examples): implicit MAML omniglot example Sep 3, 2022
@Benjamin-eecs Benjamin-eecs added this to the 0.6.0 milestone Sep 5, 2022
@XuehaiPan XuehaiPan added enhancement New feature or request example / tutorial Something related to examples or tutorials labels Sep 5, 2022
@Benjamin-eecs Benjamin-eecs removed the request for review from JieRen98 September 13, 2022 07:10
@Benjamin-eecs Benjamin-eecs marked this pull request as ready for review September 15, 2022 09:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Base: 63.16% // Head: 63.30% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (d280559) compared to base (6604625).
Patch coverage: 92.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   63.16%   63.30%   +0.14%     
==========================================
  Files          58       58              
  Lines        2302     2303       +1     
==========================================
+ Hits         1454     1458       +4     
+ Misses        848      845       -3     
Flag Coverage Δ
unittests 63.30% <92.10%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/diff/implicit/decorator.py 94.39% <91.89%> (+1.40%) ⬆️
torchopt/typing.py 95.83% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

return params


def test_imaml_inner_solver(init_params_copy, init_params, data, aux):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不直接复用train_imaml_inner_solver,test的时候再加个torch.no_grad好了,免得冗余

waterhorse1
waterhorse1 previously approved these changes Oct 31, 2022
@Benjamin-eecs Benjamin-eecs removed the request for review from XuehaiPan November 2, 2022 09:09
@Benjamin-eecs Benjamin-eecs merged commit f66107d into metaopt:main Nov 2, 2022
@Benjamin-eecs Benjamin-eecs deleted the feature/imaml-omniglot branch November 2, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request example / tutorial Something related to examples or tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implicit gradient support
5 participants