-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: make failed addon loading more informative #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it.
belochub
approved these changes
Feb 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aqrln
added a commit
that referenced
this pull request
Feb 27, 2017
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: #90
Landed in 2004786. |
aqrln
added a commit
that referenced
this pull request
Mar 13, 2017
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: #90
Merged
aqrln
added a commit
that referenced
this pull request
Mar 13, 2017
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: #90
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: #90
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: #90
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: metarhia/jstp#90
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: metarhia/jstp#90
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
* Make `common.safeRequire` print the reason of failed require() to stderr. The error wasn't passed anywhere so the reason was lost and could not be delivered to user. When the Record Serialization parser could not load its native addon, it always stated that it isn't built though the actual reason might be different. * Fix somewhat misleading language in the error message in `lib/record-serialization.js`. The addon is not only used on server. For example, when the addon was compiled with a wrong version of `node-gyp`, JSTP used to print: > JSTP native addon is not built. Run `npm install` in order to build > it, otherwise you will get poor server performance under load. and it continued to print the same message however many times `npm install` was invoked, which is certainly not very helpful. Now the error message in the same situation looks like this: > Error: The module > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node' > was compiled against a different Node.js version using > NODE_MODULE_VERSION 51. This version of Node.js requires > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing > the module (for instance, using `npm rebuild` or `npm install`). > Error: Cannot find module '../build/Debug/jstp' > JSTP native addon is not built or is not functional. Run `npm install` > in order to build it, otherwise you will get poor performance. and is certainly more helpful since it contains an obvious reference to ABI incompatibility and makes it possible to troubleshoot it. PR-URL: metarhia/jstp#90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
common.safeRequire
print the reason of failed require() tostderr. The error wasn't passed anywhere so the reason was lost
and could not be delivered to user. When the Record Serialization
parser could not load its native addon, it always stated that it
isn't built though the actual reason might be different.
Fix somewhat misleading language in the error message in
lib/record-serialization.js
. The addon is not only used on server.For example, when the addon was compiled with a wrong version of
node-gyp
, JSTP used to print:and it continued to print the same message however many times
npm install
was invoked, which is certainly not very helpful.Now the error message in the same situation looks like this:
and is certainly more helpful since it contains an obvious reference to
ABI incompatibility and makes it possible to troubleshoot it.