Commits on Feb 26, 2017

1. lib: make failed addon loading more informative …

   * Make `common.safeRequire` print the reason of failed require() to
     stderr. The error wasn't passed anywhere so the reason was lost
     and could not be delivered to user. When the Record Serialization
     parser could not load its native addon, it always stated that it
     isn't built though the actual reason might be different.
   
   * Fix somewhat misleading language in the error message in
     `lib/record-serialization.js`. The addon is not only used on server.
   
   For example, when the addon was compiled with a wrong version of
   `node-gyp`, JSTP used to print:
   
   > JSTP native addon is not built. Run `npm install` in order to build
   > it, otherwise you will get poor server performance under load.
   
   and it continued to print the same message however many times `npm
   install` was invoked, which is certainly not very helpful.
   
   Now the error message in the same situation looks like this:
   
   > Error: The module
   > '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node'
   > was compiled against a different Node.js version using
   > NODE_MODULE_VERSION 51. This version of Node.js requires
   > NODE_MODULE_VERSION 53. Please try re-compiling or re-installing
   > the module (for instance, using `npm rebuild` or `npm install`).
   > Error: Cannot find module '../build/Debug/jstp'
   > JSTP native addon is not built or is not functional. Run `npm install`
   > in order to build it, otherwise you will get poor performance.
   
   and is certainly more helpful since it contains an obvious reference to
   ABI incompatibility and makes it possible to troubleshoot it.

   

   aqrln committed Feb 26, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for e891397
   • Browse repository at this point

   Copy the full SHA

   e891397 View commit details

   Browse the repository at this point in the history