Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop excess Node versions from Travis build matrix #262

Closed
aqrln opened this issue Jul 22, 2017 · 3 comments
Closed

Drop excess Node versions from Travis build matrix #262

aqrln opened this issue Jul 22, 2017 · 3 comments

Comments

@aqrln
Copy link
Member

aqrln commented Jul 22, 2017

I'd advocate for testing only using the latest releases of Node.js 6.x, 7.x and 8.x on Travis. We use CI to find our bugs, not old and resolved Node bugs. What others think about it?

/cc @metarhia/jstp-core

@tshemsedinov
Copy link
Member

Sure, I agree

aqrln added a commit that referenced this issue Jul 22, 2017
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
@belochub
Copy link
Member

@aqrln, is Node.js 7 still supported at the moment?
As far as I remember, it must've been supported only until the end of the previous month, and if that's the case, I don't think we should enable CI builds on Node.js 7.

@aqrln
Copy link
Member Author

aqrln commented Jul 22, 2017

@belochub Node.js 7 is unsupported, right. However, I believe a fair amount of people might still be using it. I am okay with both keeping and dropping it from the CI environment.

aqrln added a commit that referenced this issue Jul 22, 2017
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
aqrln added a commit that referenced this issue Jul 22, 2017
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
@aqrln aqrln added build and removed compatibility labels Jul 22, 2017
aqrln added a commit that referenced this issue Jul 24, 2017
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
@aqrln aqrln closed this as completed in 87947ee Jul 24, 2017
nechaido pushed a commit that referenced this issue Jul 25, 2017
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit that referenced this issue Jan 22, 2018
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit that referenced this issue Jan 22, 2018
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this issue Jul 19, 2018
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: metarhia/jstp#262
Refs: metarhia/jstp#260 (comment)
PR-URL: metarhia/jstp#263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this issue Jul 19, 2018
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: metarhia/jstp#262
Refs: metarhia/jstp#260 (comment)
PR-URL: metarhia/jstp#263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this issue Jul 21, 2018
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: metarhia/jstp#262
Refs: metarhia/jstp#260 (comment)
PR-URL: metarhia/jstp#263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants