Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite the Travis config #263

Closed
wants to merge 1 commit into from
Closed

test: rewrite the Travis config #263

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jul 22, 2017 •
edited
Loading

  • Use only latests releases of Node.js 6.x, 7.x and 8.x.
  • Update Ubuntu from Precise to Trusty.
  • Don't install a custom compiler, Trusty already has one that should
    support C++11.
  • Run tests on macOS too.
  • Don't install Firefox and don't launch the fake X server since we
    don't currently have browser tests anymore. When we do, it will
    require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)

@aqrln aqrln force-pushed the test/travis-matrix branch 2 times, most recently from 8727456 to 5eb6c7b Compare July 22, 2017 12:53
@aqrln aqrln added the blocked label Jul 22, 2017
@aqrln
Copy link
Member Author

aqrln commented Jul 22, 2017

Blocked until #265 lands.

@nechaido
Copy link
Member

@aqrln #265 has landed, please rebase and run tests.

@aqrln aqrln removed the blocked label Jul 24, 2017
@aqrln
test: rewrite the Travis config
bb5273f 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
@aqrln
Copy link
Member Author

aqrln commented Jul 24, 2017

@nechaido done!

nechaido
nechaido approved these changes Jul 24, 2017
View reviewed changes
Copy link
Member

@nechaido nechaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aqrln added a commit that referenced this pull request Jul 24, 2017
@aqrln
test: rewrite the Travis config
87947ee 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented Jul 24, 2017

Landed in 87947ee.

@aqrln aqrln closed this Jul 24, 2017
@aqrln aqrln deleted the test/travis-matrix branch July 24, 2017 19:44
nechaido pushed a commit that referenced this pull request Jul 25, 2017
@aqrln @nechaido
test: rewrite the Travis config
ec17b9d 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
test: rewrite the Travis config
f966833 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
test: rewrite the Travis config
15311e0 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: #262
Refs: #260 (comment)
PR-URL: #263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
test: rewrite the Travis config
183cc96 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: metarhia/jstp#262
Refs: metarhia/jstp#260 (comment)
PR-URL: metarhia/jstp#263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
test: rewrite the Travis config
1b544bb 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: metarhia/jstp#262
Refs: metarhia/jstp#260 (comment)
PR-URL: metarhia/jstp#263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
@aqrln @belochub
test: rewrite the Travis config
9353726 
* Use only latests releases of Node.js 6.x, 7.x and 8.x.
* Update Ubuntu from Precise to Trusty.
* Don't install a custom compiler, Trusty already has one that should
  support C++11.
* Run tests on macOS too.
* Don't install Firefox and don't launch the fake X server since we
  don't currently have browser tests anymore.  When we do, it will
  require to rewrite that part of the config in a cross-platform manner.

Fixes: metarhia/jstp#262
Refs: metarhia/jstp#260 (comment)
PR-URL: metarhia/jstp#263
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nechaido nechaido nechaido approved these changes

Assignees
No one assigned
Labels
build macos test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqrln @nechaido