build: fix building with Node.js 6 on macOS #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
aqrln
force-pushed
the
fix/macos-node6
branch
2 times, most recently
from
ac02166
to
fc9cb1d
Compare
belochub
approved these changes
Jul 24, 2017
aqrln
added a commit
that referenced
this pull request
Jul 24, 2017
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: #265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in 5ed6bf0. |
nechaido
pushed a commit
that referenced
this pull request
Jul 25, 2017
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: #265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: #265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: #265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: metarhia/jstp#265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: metarhia/jstp#265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit `-stdlib=libc++` as
one of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
../src/parser.cc:10:10: fatal error: 'cstdint' file not found
This patch adds the flag to OTHER_CPLUSPLUSFLAGS. It causes no harm
when using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.
PR-URL: metarhia/jstp#265
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 6.11.1 bundles npm 3.10.10, which bundles node-gyp 3.4.0. The
problem with this version is that it doesn't emit
-stdlib=libc++asone of clang flags by default, which causes it to use old GCC 4.2
headers instead of clang headers. Because of that, compilation fails
with:
This patch adds the flag to
OTHER_CPLUSPLUSFLAGS. It causes no harmwhen using newer node-gyp because duplicate flags are ignored, but
enables building JSTP with vanilla Node.js 6.x on macOS.