npm: don't publish tests in the npm package #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space.
belochub
pushed a commit
that referenced
this pull request
May 15, 2017
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in d333120. |
nechaido
pushed a commit
that referenced
this pull request
May 18, 2017
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Given that metarhia/jstp#158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: metarhia/jstp#159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Given that metarhia/jstp#158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: metarhia/jstp#159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Given that metarhia/jstp#158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: metarhia/jstp#159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that #158 has introduced
quite a massive chunk of test fixtures, it is better to avoid including
tests with the npm package. At this point it saves 632 KB of disk
space.