test: add JSON5 specs test suite #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures.
aqrln
added a commit
that referenced
this pull request
May 11, 2017
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space.
nechaido
approved these changes
May 11, 2017
|
@metarhia/jstp-core I am going to go ahead and land this by the end of the day but I'd like to get at least two reviews. |
belochub
reviewed
May 12, 2017
| const tap = require('tap'); | ||
| const jstp = require('../..'); | ||
|
|
||
| const supportedByUs = { |
There was a problem hiding this comment.
We should add noctal number tests here, because we decided before that we support them.
lundibundi
approved these changes
May 12, 2017
|
@belochub @lundibundi I've added noctal tests. |
aqrln
added a commit
that referenced
this pull request
May 12, 2017
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: #158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in e9db526. Thanks for the reviews! |
belochub
pushed a commit
that referenced
this pull request
May 15, 2017
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
nechaido
pushed a commit
that referenced
this pull request
May 18, 2017
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: #158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
nechaido
pushed a commit
that referenced
this pull request
May 18, 2017
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: #158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: #158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Given that #158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: #159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
belochub
added a commit
that referenced
this pull request
Jan 23, 2018
This is a new and shiny first major release for `metarhia-jstp`.
Changes include API refactoring and improvements, implementations of
CLI, sessions, and application versions, native addon build optimizations,
lots of bug fixes, test coverage increase, and other, less notable changes.
This release also denotes the bump of the protocol version to v1.0.
The only difference from the previous version of the protocol is that
"old" heartbeat messages (`{}`) are now deprecated and `ping`/`pong`
messages must be used for this purpose instead.
Notable changes:
* **src,build:** improve the native module subsystem
*(Alexey Orlenko)*
[#36](#36)
**\[semver-minor\]**
* **build:** compile in ISO C++11 mode
*(Alexey Orlenko)*
[#37](#37)
**\[semver-minor\]**
* **build:** improve error handling
*(Alexey Orlenko)*
[#40](#40)
**\[semver-minor\]**
* **lib:** refactor record-serialization.js
*(Alexey Orlenko)*
[#41](#41)
* **parser:** fix a possible memory leak
*(Alexey Orlenko)*
[#44](#44)
**\[semver-minor\]**
* **protocol:** change the format of handshake packets
*(Alexey Orlenko)*
[#54](#54)
**\[semver-major\]**
* **parser:** make parser single-pass
*(Mykola Bilochub)*
[#61](#61)
* **parser:** remove special case for '\0' literal
*(Mykola Bilochub)*
[#68](#68)
**\[semver-major\]**
* **parser:** fix bug causing node to crash
*(Mykola Bilochub)*
[#75](#75)
* **client:** drop redundant callback argument
*(Alexey Orlenko)*
[#104](#104)
**\[semver-major\]**
* **client:** handle errors in connectAndInspect
*(Alexey Orlenko)*
[#105](#105)
**\[semver-major\]**
* **socket,ws:** use socket.destroy() properly
*(Alexey Orlenko)*
[#84](#84)
**\[semver-major\]**
* **cli:** add basic implementation
*(Mykola Bilochub)*
[#107](#107)
**\[semver-minor\]**
* **connection:** fix error handling in optional cbs
*(Alexey Orlenko)*
[#147](#147)
**\[semver-major\]**
* **test:** add JSON5 specs test suite
*(Alexey Orlenko)*
[#158](#158)
* **lib:** change event signature
*(Denys Otrishko)*
[#187](#187)
**\[semver-major\]**
* **lib:** add address method to Server
*(Denys Otrishko)*
[#190](#190)
**\[semver-minor\]**
* **parser:** implement NaN and Infinity parsing
*(Mykola Bilochub)*
[#201](#201)
* **parser:** improve string parsing performance
*(Mykola Bilochub)*
[#220](#220)
* **lib:** optimize connection events
*(Denys Otrishko)*
[#222](#222)
**\[semver-major\]**
* **lib:** refactor server and client API
*(Denys Otrishko)*
[#209](#209)
**\[semver-major\]**
* **lib,src:** rename term packet usages to message
*(Denys Otrishko)*
[#270](#270)
**\[semver-major\]**
* **lib:** emit events about connection messages
*(Denys Otrishko)*
[#252](#252)
**\[semver-minor\]**
* **lib:** implement API versioning
*(Denys Otrishko)*
[#231](#231)
**\[semver-minor\]**
* **lib:** allow to set event handlers in application
*(Denys Otrishko)*
[#286](#286)
**\[semver-minor\]**
* **lib:** allow to broadcast events from server
*(Denys Otrishko)*
[#287](#287)
**\[semver-minor\]**
* **connection:** make callback method private
*(Alexey Orlenko)*
[#306](#306)
**\[semver-major\]**
* **lib:** implement sessions
*(Mykola Bilochub)*
[#289](#289)
**\[semver-major\]**
* **connection:** use ping-pong instead of heartbeat
*(Dmytro Nechai)*
[#303](#303)
**\[semver-major\]**
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: metarhia/jstp#158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Given that metarhia/jstp#158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: metarhia/jstp#159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: metarhia/jstp#158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Given that metarhia/jstp#158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: metarhia/jstp#159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
This commit adds and adapts the official JSON5 parser tests. `test/todo/json5.js` should be moved to `test/node` as soon as we fix all the failures. PR-URL: metarhia/jstp#158 Refs: https://github.com/metarhia/JSTP/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Given that metarhia/jstp#158 has introduced quite a massive chunk of test fixtures, it is better to avoid including tests with the npm package. At this point it saves 632 KB of disk space. PR-URL: metarhia/jstp#159 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds and adapts the official JSON5 parser tests.
test/todo/json5.jsshould be moved totest/nodeas soon as we fixall the failures.