Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,lib,test,tools: update ESLint to 4.x #242

Closed
wants to merge 2 commits into from
Closed

deps,lib,test,tools: update ESLint to 4.x #242

wants to merge 2 commits into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jun 27, 2017

Update ESLint and eslint-plugin-import, and fix linter errors that the newer and stricter indent rule reports.

belochub
belochub approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nechaido
nechaido approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@nechaido nechaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lundibundi
lundibundi approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqrln aqrln mentioned this pull request Jun 27, 2017
Closed
@aqrln
Copy link
Member Author

aqrln commented Jun 28, 2017 •
edited
Loading

Landed in 5ccc45d and 0c561fc.

@aqrln aqrln closed this Jun 28, 2017
@aqrln aqrln deleted the update-eslint branch June 28, 2017 15:23
aqrln added a commit that referenced this pull request Jun 28, 2017
@aqrln
lib,test,tools: fix linter errors with ESLint 4
5ccc45d 
PR-URL: #242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
aqrln added a commit that referenced this pull request Jun 28, 2017
@aqrln
deps: update ESLint and eslint-plugin-import
0c561fc 
Refs: #243
PR-URL: #242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
lib,test,tools: fix linter errors with ESLint 4
c19c51c 
PR-URL: #242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
deps: update ESLint and eslint-plugin-import
c42206e 
Refs: #243
PR-URL: #242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
lib,test,tools: fix linter errors with ESLint 4
3e70f7f 
PR-URL: #242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
deps: update ESLint and eslint-plugin-import
35479fa 
Refs: #243
PR-URL: #242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
lib,test,tools: fix linter errors with ESLint 4
d40f1eb 
PR-URL: metarhia/jstp#242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
lib,test,tools: fix linter errors with ESLint 4
8e05f85 
PR-URL: metarhia/jstp#242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
@aqrln @belochub
lib,test,tools: fix linter errors with ESLint 4
102b262 
PR-URL: metarhia/jstp#242
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nechaido nechaido nechaido approved these changes

@lundibundi lundibundi lundibundi approved these changes

@belochub belochub belochub approved these changes

Assignees
No one assigned
Labels
deps lib test tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aqrln @belochub @lundibundi @nechaido