Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps,lib,test,tools: update ESLint to 4.x #242

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cli/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ utils.split = (str, separator, limit, leaveEmpty) => {
let start = 0;

const shouldPush = end =>
start !== end || (leaveEmpty && result[result.length - 1] !== '');
start !== end || (leaveEmpty && result[result.length - 1] !== '');

// eslint-disable-next-line no-unmodified-loop-condition
while (!limit || result.length < limit) {
Expand Down
4 changes: 2 additions & 2 deletions lib/record-serialization-fallback.js
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@ JsrsParser.prototype.parseNumber = function() {

const value = (
base === 10 ?
this.parseDecimal() :
this.parseMachineInteger(base)
this.parseDecimal() :
this.parseMachineInteger(base)
);

if (isNaN(value)) {
Expand Down
20 changes: 10 additions & 10 deletions lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ class Server {
getClients() {
if (this._cachedClientsArray.length === 0) {
this._cachedClientsArray = Object.keys(this.clients)
.map(cid => this.clients[cid]);
.map(cid => this.clients[cid]);
}

return this._cachedClientsArray;
}

// Handler of a new connection event emitter from the underlying server.
// socket - a lower-level socket or connection
//
// Handler of a new connection event emitter from the underlying server.
// socket - a lower-level socket or connection
//
_onRawConnection(socket) {
const connection = new Connection(this.createTransport(socket), this);

Expand All @@ -84,17 +84,17 @@ class Server {
});
}

// Client connection event handler.
// connection - JSTP connection instance
//
// Client connection event handler.
// connection - JSTP connection instance
//
_onClientConnect(connection) {
this.clients[connection.id] = connection;
this._cachedClientsArray.push(connection);
}

// Client connection close event handler.
// connection - JSTP connection instance
//
// Client connection close event handler.
// connection - JSTP connection instance
//
_onClientDisconnect(connection) {
delete this.clients[connection.id];
this._cachedClientsArray = [];
Expand Down
2 changes: 1 addition & 1 deletion lib/transport-common.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const newCreateServerFn = serverClass => (options, ...other) => {
if (Array.isArray(options)) {
options = { applications: options };
}
// eslint-disable-next-line new-cap
// eslint-disable-next-line new-cap
return new serverClass(options, ...other);
};

Expand Down
Loading