Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non compliant json #1290

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fix non compliant json #1290

merged 2 commits into from
Jul 30, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jul 30, 2024

Change Summary

Should fix the issue where aerovaldb wrote non-compliant json which aeroval-web could not parse.

Caps xarray to 2024.06 max which is a workaround for #1289

Related issue number

closes #1288

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Additional Context

metno/aerovaldb#59

@thorbjoernl thorbjoernl added the bug 🐛 Something isn't working label Jul 30, 2024
@thorbjoernl thorbjoernl self-assigned this Jul 30, 2024
@thorbjoernl thorbjoernl added this to the m2024-08 milestone Jul 30, 2024
@thorbjoernl thorbjoernl requested a review from charlienegri July 30, 2024 10:53
@thorbjoernl thorbjoernl marked this pull request as ready for review July 30, 2024 10:53
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (96cc0b0) to head (d349722).
Report is 326 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1290   +/-   ##
=========================================
  Coverage     78.96%   78.96%           
=========================================
  Files           136      136           
  Lines         20842    20842           
=========================================
  Hits          16458    16458           
  Misses         4384     4384           
Flag Coverage Δ
unittests 78.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl merged commit 0dd1f8e into main-dev Jul 30, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the fix-non-compliant-json branch July 30, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyaerocom writes non-standard json files which can't be parsed by aeroval-web.
2 participants