Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fail with xarray 2024.7.0 #1289

Closed
avaldebe opened this issue Jul 30, 2024 · 1 comment · Fixed by #1292
Closed

test fail with xarray 2024.7.0 #1289

avaldebe opened this issue Jul 30, 2024 · 1 comment · Fixed by #1292
Assignees
Labels
bug 🐛 Something isn't working testing
Milestone

Comments

@avaldebe
Copy link
Collaborator

Describe the bug
Please provide a clear and concise description of what the bug is.

  • Pyaerocom version: 0.21.0.dev0
  • Computing platform: Ubuntu 22.04.4 LTS and CI
  • Configuration file (if applicable):
  • Error message (if applicable):
        indexer = either_dict_or_kwargs(indexer, indexer_kwargs, "resample")
        if len(indexer) != 1:
>           raise ValueError("Resampling only supported along single dimensions.")
E           ValueError: Resampling only supported along single dimensions.

.tox/py311/lib/python3.11/site-packages/xarray/core/common.py:1056: ValueError 

To Reproduce
Steps to reproduce the behavior:

tox -re py311 -- tests/aeroval/test_aeroval_HIGHLEV.py -vvx

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@avaldebe avaldebe added bug 🐛 Something isn't working testing labels Jul 30, 2024
avaldebe added a commit that referenced this issue Jul 30, 2024
@thorbjoernl
Copy link
Collaborator

Deprecation of base and loffsetcauses loffset to be picked up as an indexer which is what causes the exception.

pydata/xarray#9233

https://docs.xarray.dev/en/stable/whats-new.html#breaking-changes

Using the origin or offset parameters is recommended as a replacement for using the base parameter and using time offset arithmetic is recommended as a replacement for using the loffset parameter. (PR9233) By Deepak Cherian.

I think the replacements are not supported by the oldest version of xarray which we currently support which means we either need to bump the oldest supported xarray version or have special logic (I vote for the former).

@thorbjoernl thorbjoernl self-assigned this Jul 30, 2024
@thorbjoernl thorbjoernl added this to the m2024-08 milestone Jul 30, 2024
lewisblake pushed a commit that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants