Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xarray 2024.7.0 errors #1292

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Fix xarray 2024.7.0 errors #1292

merged 6 commits into from
Aug 6, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jul 30, 2024

Change Summary

Resolve errors caused by removal of deprecated resample parameters in xarray 2024.7.0

The oldest version of xarray which supports base and offset is xarray 2022.12.0, which is set as the new oldest supported version (previously 2022.10.0).

Related issue number

closes #1289

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies labels Jul 30, 2024
@thorbjoernl thorbjoernl self-assigned this Jul 30, 2024
@thorbjoernl thorbjoernl added this to the m2024-08 milestone Jul 30, 2024
@thorbjoernl thorbjoernl marked this pull request as ready for review July 30, 2024 13:39
@thorbjoernl thorbjoernl requested a review from lewisblake July 30, 2024 13:39
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (1a3c12e) to head (c4b993d).
Report is 317 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1292      +/-   ##
============================================
+ Coverage     78.96%   78.98%   +0.02%     
============================================
  Files           136      136              
  Lines         20842    20793      -49     
============================================
- Hits          16458    16424      -34     
+ Misses         4384     4369      -15     
Flag Coverage Δ
unittests 78.98% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lewisblake lewisblake merged commit 6305c31 into main-dev Aug 6, 2024
8 checks passed
@lewisblake lewisblake deleted the fix-xarray-issue branch August 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test fail with xarray 2024.7.0
2 participants