Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosie disco: wsgi - replace tornado with a wsgi compatible server #2492

Open
oliver-sanders opened this issue Nov 2, 2021 · 3 comments
Open

rosie disco: wsgi - replace tornado with a wsgi compatible server #2492

oliver-sanders opened this issue Nov 2, 2021 · 3 comments
Milestone
2.x

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 2, 2021 •
edited
Loading

WSGI support has been removed at Tornado 6 which has broken rosie disco.

tornadoweb/tornado#2792

Need to fix the issue or pin tornado to <6.0 (which may conflict with other parts of the stack).

Need to swap Tornado for a WSGI compatible web framework.
@oliver-sanders oliver-sanders added this to the 2.0.0 milestone Nov 2, 2021
@oliver-sanders oliver-sanders self-assigned this Nov 3, 2021
@oliver-sanders
Copy link
Member Author

Note, need to go over rosie disco functionality at the same time to ensure it's all working, rosie disco stop has broken.

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 8, 2021 •
edited
Loading

Jupyter Server is pinned at tornado>=6.1 which brings us into conflict:

  • env
    • metomi-rose
      • tornado < 6.0
    • cylc-uiserver
      • jupyter_server
        • tornado >= 6.1

We will have to drop Tornado for a WSGI compatible web framework.

@oliver-sanders oliver-sanders changed the title rosie disco: tornado 6.0+ compatibility rosie disco: wsgi - replace tornado with a wsgi compatible server Nov 8, 2021
oliver-sanders added a commit to oliver-sanders/rose that referenced this issue Nov 8, 2021
@oliver-sanders
disco: temporarily disable disco
8539237 
* Tornado 6+ does not support WSGI.
* Disable it for now, fix later.
* See metomi#2492
@oliver-sanders oliver-sanders mentioned this issue Nov 8, 2021
Merged
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, 2.0b3 Nov 9, 2021
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 10, 2021 •
edited
Loading

Removing the bug after #2493, bumping to 2.0.0.

@oliver-sanders oliver-sanders removed their assignment Nov 19, 2021
@wxtim wxtim mentioned this issue Nov 22, 2021
Closed
@wxtim wxtim modified the milestones: 2.0rc1, 2.x Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
2 participants
@oliver-sanders @wxtim