disco: temporarily disable disco #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliver-sanders
commented
Nov 8, 2021
oliver-sanders
commented
- Tornado 6+ does not support WSGI.
- Disable it for now, fix later.
- See rosie disco: wsgi - replace tornado with a wsgi compatible server #2492
* Tornado 6+ does not support WSGI. * Disable it for now, fix later. * See metomi#2492
MetRonnie
reviewed
Nov 9, 2021
|
Eh, could do, it's only us who care about this feature. |
|
Put one in for the hell of it. |
MetRonnie
requested changes
Nov 9, 2021
datamel
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
I've checked out the branch and can confirm this is disabled. I'm happy for merge once @MetRonnie is.
oliver-sanders
force-pushed
the
rosie-disco
branch
from
25471ab to
e7c62e5
Compare
|
Hmm https://github.com/metomi/rose/runs/4164101189?check_suite_focus=true#step:5:161 Is that because for the docs build test we're not using the GitHub dev version of cylc-flow, instead we're using PyPI version? |
|
Might as well squeeze a fix for that in here too... |
|
Docs passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.