Re-enable Rosie ID. #2510
Re-enable Rosie ID. #2510
Conversation
Update: Tried again this morning with a fresh environment and this has fixed my problems @wxtim. I think pip installing (including cache clearing) everything is not enough sometimes. |
| vcsystem = None | ||
| url = None | ||
| rev = None | ||
| for line in fpath.read_text().split('\n'): |
There was a problem hiding this comment.
Is it not possible to parse this using Rose's parser? I guess not because Rose doesn't allow multiline strings like
status = """
M flow.cylc
M whatever.txt
"""
?
Then perhaps it would make sense to save VCS info as JSON instead, as you suggested. Which I think would have to be a Cylc 8.0rc1 PR...
There was a problem hiding this comment.
It's an internal which users shouldn't see: so IMO we should create an issue to change this beyond rc1. I don't think that it needs to be a blocker.
If we want to be failsafe I can't think that it'd be massively expensive to write this + json both.
Closes #2432
Requires #2509 merger to pass