Update rosie id to use new JSON format for Cylc VCS logs
#2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Dec 7, 2021
7 tasks
|
(merged the sibling PR) |
| # these cause import issues | ||
| --ignore=metomi/rose/etc/ | ||
| --ignore=metomi/rosie/ws.py | ||
| --ignore=metomi/rosie/graph.py |
There was a problem hiding this comment.
I don't have any import issues here:
Suggested change
| --ignore=metomi/rosie/graph.py |
There was a problem hiding this comment.
Was passing for me locally, but on GH Actions:
=========================== short test summary info ============================
ERROR metomi/rosie/graph.py - ModuleNotFoundError: No module named 'pygraphviz'
ERROR metomi/rosie/ws.py - ModuleNotFoundError: No module named 'tornado'
https://github.com/metomi/rose/runs/4459717007?check_suite_focus=true#step:11:23
Actualy, on second thought, shouldn't we include pygraphviz as a dependency of Rose if it imports it?
wxtim
reviewed
Dec 9, 2021
| if url and rev: | ||
| location = url + "@" + rev | ||
| return location | ||
| with open(fpath, 'r') as f: |
wxtim
approved these changes
Dec 9, 2021
|
Approved without merging to allow you to respond or not to Oliver's unresolved comment. |
|
Actually, IMO we should merge, but create a new issue, or just collar Oliver on Monday. |
|
Merging now, created a new issue for pygraphviz here: #2523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to cylc/cylc-flow#4548 (needs merging first for tests to pass here). Follow-up to #2510.