Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QC summary template #106

Closed
wants to merge 5 commits into from
Closed

Update QC summary template #106

wants to merge 5 commits into from

Conversation

michaelmcd18
Copy link
Collaborator

No description provided.

@michaelmcd18 michaelmcd18 linked an issue Jun 20, 2024 that may be closed by this pull request
@andersone1
Copy link
Collaborator

@michaelmcd18 Include "Days Since Last Rev"

@andersone1
Copy link
Collaborator

image

@michaelmcd18
Copy link
Collaborator Author

Screenshot 2024-06-25 at 10 32 25 AM

@andersone1 A couple updates done to this table, added a Days since last edit column. Also now have text wrapping for the File column so the table will always stay on the page, regardless of file path length

@michaelmcd18
Copy link
Collaborator Author

Screenshot 2024-06-25 at 10 33 52 AM @andersone1 Also updated the author/directory table to reduce datetime to date and add in revision number of last edit

@michaelmcd18
Copy link
Collaborator Author

example-sum.pdf

Realizing now I could've just uploaded the new pdf output instead of screenshots

@seth127
Copy link
Collaborator

seth127 commented Jul 8, 2024

@michaelmcd18 drive-by comment: can we put the revision number (i.e. the most recent at the time this summary was cut) at the top of the doc? Probably right under the date stamp, something like "Summary as of revision ___".

Any thoughts on that?

@michaelmcd18
Copy link
Collaborator Author

at_risk_days <- 30

not_in_log <-
  dir_summary_data %>%
  dplyr::filter(grepl("script/", File, fixed = TRUE)) %>%  # Just filter out data
  dplyr::filter(Status == "Not in QC log") %>% 
  dplyr::mutate(
    `Latest edit` = as.Date(`Latest edit`),
    `Days since...last edit` = as.numeric(Sys.Date() - `Latest edit`)) %>% 
  dplyr::filter(`Days since...last edit` <= at_risk_days) %>% 
  dplyr::select(File, Author, `Days since...last edit`) %>% 
  dplyr::arrange(`Days since...last edit`)

if (nrow(not_in_log) == 0) {
  not_in_log <- dplyr::tibble(Author = "None", File = paste0("No files modified within the last ", at_risk_days, " days"))
}

not_in_log %>%   
  pmtables::st_new() %>% 
  pmtables::st_center(File = pmtables::col_ragged(8)) %>% # Increase width restriction since only 3 columns 
  pmtables::stable_long() %>%
  pmtables::st_asis()

@andersone1 andersone1 deleted the update-qc-summary branch November 13, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renderQCSummary updates
3 participants