Feedback check in for #117 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added Core.animLayer module
- added more layer functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #117
I have added some new layer handling tools and updated some of the fps calls to use some of the newer mGear.Core.util methods that are more robust.
I did some tests regarding creating clips, having animation layers, and exporting with some on and off and so far it all looks good. I feel like I have missed an issue or something along those lines as there is a lot mentioned in #117 but I am not 100% sure what we should be achieving in this branch compared to the entirety of the ticket.
@miquelcampos let me know what you think, maybe give this a quick try and we do a catch up call later this evening?