Allow Github Actions to be run on non-master branch

[dolfinus]

Hi.

I've added a small fix to your Github Actions workflow definition - now it will be executed while pushing commit to any branch instead of just master.
This allows users like me create multiple pull requests from different branches of their fork repos to the master branch of your repo, and still be able to see if something is wrong with the source code.

[mgedmin]

This should not be necessary -- when you create a pull request, the 'on: pull_request' trigger performs the build.

What will happen if I merge this, any PR created from a branch in this repository will have all the jobs doubled: once for the pull_request trigger, and once for the branch trigger. I don't want that.

[dolfinus]

Hi.

when you create a pull request, the 'on: pull_request' trigger performs the build.

Right, but it would not run workflow on a forked repo until I make a pull request. More than that, it will not be run until an author of the original repo will open this PR and approve a workflow execution.
This is a way to prevent executing workflows with cryptocurrency miners introduced by Github on April 2021.

Because of that limiting a workflow run with a specific branch is not a best option. For example, I've created a pull request #64 and I has been waited for 2 weeks for the workflow to be approved by you just to ensure that my changes are correct. And only after workflow has been executed I discovered that one of steps failed.

any PR created from a branch in this repository will have all the jobs doubled

Regarding the issue of executing a workflow twice when a PR is created within the same repo, there are other ways to prevent that.
For example, I'm using fkirc/skip-duplicate-actions action:
https://github.com/dolfinus/arkenston-backend/blob/4f1f30513ec2c8c1532986141b9e10451fe9c556/.github/workflows/test.yml#L10-L29

It prevents workflow from being run if there is another copy of workflow which has been triggered by the same commit.

[mgedmin]

Ooh, the skipping of the duplicate action thing sounds interesting. I don't currently have the energy to investigate it (or review the long-standing open PRs, sorry about that, I'm trying!). Would you mind amending this PR so I can see what the result looks like?

[mgedmin]

Hm, actually, to really see what it would look like, I think I have to add you as a collaborator to this repo, so you can create branches in it. Otherwise there's no duplicates to hide, right?

[dolfinus]

Sorry for late response.

Would you mind amending this PR so I can see what the result looks like?

Of course not. I've amended this PR several times.

I think I have to add you as a collaborator to this repo, so you can create branches in it. Otherwise there's no duplicates to hide, right?

Actually, I can show you how it works on a forked repo.

For example, I've pushed a commit and then amended (without adding any changes) it and pushed again.
So workflow has been triggered by the first commit:
https://github.com/dolfinus/objgraph/actions/runs/1586725848
But next one has been skipped:
https://github.com/dolfinus/objgraph/actions/runs/1586726837
If there are some changes in the new commit, next build will not be skipped.

Also I've created a new branch and PR.
PR build was triggered successfully:
https://github.com/dolfinus/objgraph/actions/runs/1586753567
But duplicated one caused by commit has been skipped:
https://github.com/dolfinus/objgraph/actions/runs/1586753367