Merge cockroachdb#93048 cockroachdb#93050

93048: build: pass artifacts dir to Pebble crossversion tests r=jbowens a=jbowens

Adjust the build script that runs the nightly Pebble crossversion metamorphic tests to propagate the artifacts directory, ensuring the test's history and data from failures make it into teamcity.

Epic: None
Release note: None

93050: roachtest: move flaky test to activerecord ignore list r=rafiss a=andyyang890

This patch moves a flaky test from the blocklist to the ignore list
for the activerecord roachtest.

Fixes cockroachdb#92973

Release note: None

Co-authored-by: Jackson Owens <jackson@cockroachlabs.com>
Co-authored-by: Andy Yang <yang@cockroachlabs.com>

build/teamcity/cockroach/nightlies/pebble_nightly_metamorphic_crossversion_impl.sh

@@ -26,8 +26,8 @@ BAZEL_BIN=$(bazel info bazel-bin --config ci)
 # to set the arguments appropriately.
 test_args=$(echo $@ | python3 -c "import sys; print(' '.join(['--test_arg=' +word.strip() for word in sys.stdin.read().split(' ')]))")
 
-# Add the verbosity flag.
-test_args="--test_arg=-test.v $test_args"
+# Add the verbosity and artifacts flags.
+test_args="--test_arg=-artifacts --test_arg ${ARTIFACTS_DIR} --test_arg=-test.v $test_args"
 
 $BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci -- \
  test @com_github_cockroachdb_pebble//internal/metamorphic/crossversion:crossversion_test \

pkg/cmd/roachtest/tests/activerecord_blocklist.go

@@ -33,9 +33,7 @@ var activeRecordBlocklist = blocklist{
  "PostgresqlRangeTest#test_timezone_array_awareness_tsrange": "27791",
  "PostgresqlRangeTest#test_timezone_array_awareness_tzrange": "27791",
  // TODO(yang): investigate cause further
- "PostgreSQLReferentialIntegrityTest#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas": "unknown",
- "PostgresqlTimestampWithAwareTypesTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_time_zone_set": "expected ActiveSupport::TimeWithZone, not Time",
- "PostgresqlTimestampWithTimeZoneTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_timestamptz_and_time_zone_set": "expected ActiveSupport::TimeWithZone, not Time",
+ "PostgreSQLReferentialIntegrityTest#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas": "unknown",
 }
 
 var activeRecordIgnoreList = blocklist{
@@ -73,6 +71,8 @@ var activeRecordIgnoreList = blocklist{
  "LengthValidationTest#test_validates_size_of_association_using_within": "flaky - sometimes complains that a relation does not exist",
  "PostgresqlInfinityTest#test_where_clause_with_infinite_range_on_a_datetime_column": "flaky - sometimes complains that a relation does not exist",
  "PostgresqlIntervalTest#test_interval_type": "flaky",
+ "PostgresqlTimestampWithAwareTypesTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_time_zone_set": "flaky - sometimes complains given Time instead of ActiveSupport::TimeWithZone",
+ "PostgresqlTimestampWithTimeZoneTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_timestamptz_and_time_zone_set": "flaky - sometimes complains given Time instead of ActiveSupport::TimeWithZone",
  "RelationTest#test_finding_last_with_arel_order": "flaky - sometimes complains that a relation does not exist",
  "RelationTest#test_joins_with_select_custom_attribute": "flaky - sometimes complains that a relation does not exist",
  "RelationTest#test_order_triggers_eager_loading_when_ordering_using_hash_syntax": "flaky - sometimes complains that a relation does not exist",