optimizing getRadioItems #1406
Merged
optimizing getRadioItems #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think. Should we replace all of these by CBATeam/CBA_A3#902? |
dedmen
approved these changes
Apr 26, 2018
|
sure, why not. |
|
won't use the CBA func because that doesn't have the option to leave duplicates. |
dedmen
pushed a commit
that referenced
this pull request
Jun 17, 2019
Former-commit-id: 04bb27b9c2ec27518439a3d9c33b32f78fb092bf [formerly 4da4e16539d5e5bd06f0ea29a8717253cf5ca9f9] [formerly 76296ed6e416e5341a37ddd4bd05a75d08d57c81 [formerly 0b5cb926f073b311e2711cf6c67a64923ec29127]] [formerly 1ff03bbead7243f8dda780fb753eba40fb0f0fbc [formerly f455e6ec58f64b81e922773cfa1243dc2745acec] [formerly b623ed6b94b8c9d1e80cae6e90ce56aaee700dc5 [formerly 9b19d12e8916cc184cae8ec65198380713d7250c]]] Former-commit-id: 4207f727c9775a690746d4d9304bd82372cb772a [formerly 7416e25311072e4873da3da2861382330ee7cff9] [formerly 9110634b3e007f867ddf6e4a84fac9d8d48ddcbf [formerly d6f7e8e97fb785a384784c85c6831b48f10b83a4]] Former-commit-id: 417cbfde088cf55cc9f4707eaf5a0252dbab1273 [formerly bea35868ff1bbadedea3be214ecf653b5ea1f856] Former-commit-id: f247a13d65eff522eae8e59bdda23cb4a3ab34db
dedmen
pushed a commit
that referenced
this pull request
Jun 17, 2019
Former-commit-id: 04bb27b9c2ec27518439a3d9c33b32f78fb092bf [formerly 4da4e16539d5e5bd06f0ea29a8717253cf5ca9f9] [formerly 76296ed6e416e5341a37ddd4bd05a75d08d57c81 [formerly 0b5cb926f073b311e2711cf6c67a64923ec29127]] [formerly 1ff03bbead7243f8dda780fb753eba40fb0f0fbc [formerly f455e6ec58f64b81e922773cfa1243dc2745acec] [formerly b623ed6b94b8c9d1e80cae6e90ce56aaee700dc5 [formerly 9b19d12e8916cc184cae8ec65198380713d7250c]]] Former-commit-id: 4207f727c9775a690746d4d9304bd82372cb772a [formerly 7416e25311072e4873da3da2861382330ee7cff9] [formerly 9110634b3e007f867ddf6e4a84fac9d8d48ddcbf [formerly d6f7e8e97fb785a384784c85c6831b48f10b83a4]] Former-commit-id: 417cbfde088cf55cc9f4707eaf5a0252dbab1273 [formerly bea35868ff1bbadedea3be214ecf653b5ea1f856] Former-commit-id: f247a13d65eff522eae8e59bdda23cb4a3ab34db Former-commit-id: de7afc8
dedmen
pushed a commit
that referenced
this pull request
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix function header
optimize the function