Add CBA_fnc_uniqueUnitItems #902

dedmen · 2018-03-19T07:23:54Z

Default settings return the same as items _unit but without duplicates.

iterating over items unit like in
https://github.com/acemod/ACE3/blob/8548ff7eb8fd055c5013225b6acb620c753892a4/addons/tagging/functions/fnc_addTagActions.sqf#L36

_requiredItem in ((items _unit) apply {toLower _x})

Can be very expensive if you are just searching for whether the player has one item. Because it returns all items and multiple items as multiple strings.

Was a total perf killer in TFAR when someone had a backpack with ACE medical supplies. I'm sure this can be useful for many things.

Also made it configurable as you might want to exclude backpack or include weapon items.

I don't know how I could make unit tests for this. And I also don't quite like the current Name. My creativity has it's limits.

Dystopian · 2018-03-19T07:52:57Z

maybe getUniqueItems because not only players but any units?

jonpas

Rename to getUniqueItems or getUnitUniqueItems (former could work on boxes too if that makes sense).

jonpas · 2018-03-19T07:59:24Z

addons/common/fnc_getUniquePlayerItems.sqf

+    _allItems append (primaryWeaponItems _unit);
+    _allItems append (secondaryWeaponItems _unit);
+    _allItems append (handgunItems _unit);
+    _allItems append [  primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit,


Array contents to new line, one indent right.

_allItems append [ primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit, primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit ];

Or

_allItems append [ primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit, primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit ];

? I'm confused now.

_allItems append [ primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit, primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit ];

jonpas · 2018-03-19T08:00:00Z

addons/common/fnc_getUniquePlayerItems.sqf

+    _allItems append (handgunItems _unit);
+    _allItems append [  primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit,
+                        primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit
+                     ];


Same indent as _allItems append ....

jonpas · 2018-03-19T08:00:09Z

addons/common/fnc_getUniquePlayerItems.sqf

+    _allItems append (secondaryWeaponItems _unit);
+    _allItems append (handgunItems _unit);
+    _allItems append [  primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit,
+                        primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit


Only one indent right.

jonpas · 2018-03-19T08:02:12Z

Was a total perf killer in TFAR when someone had a backpack with ACE medical supplies. I'm sure this can be useful for many things.

Same thing in ACRE, will be beneficial.

Soldia1138 · 2018-03-19T08:13:32Z

Great idea. So maybe this can be a starter to offer a unique ID framework within CBA?
There are quite a few use cases where a unique ID are beneficial.

TheMagnetar · 2018-03-19T08:41:10Z

Same thing in ACRE, will be beneficial.

And ACE BFT as well

commy2 · 2018-03-19T09:14:12Z

How does this compare to:

params [["_unit", objNull, [objNull]];

private _items = items _unit;
_items arrayIntersect _items // return

?

commy2 · 2018-03-19T09:21:11Z

Naming sheme:

the "get" prefix may or may not be optional
"player" vs. "unit": this works on all units (persons), so "unit" instead of "player"
pushBack, pushBackUnique: the "unique" qualifier is used as suffix
I'd try to make it a 3 word compound if possible (easier to remember)

So my suggestions are:

CBA_fnc_getUnitItemsUnique
CBA_fnc_unitItemsUnique
CBA_fnc_getItemsUnique
CBA_fnc_itemsUnique

commy2 · 2018-03-19T09:26:35Z

This function does not report the binocularMagazine as far as I can tell.

commy2 · 2018-03-19T09:32:41Z

addons/common/fnc_getUniquePlayerItems.sqf

+Function: CBA_fnc_getUniquePlayerItems
+
+Description:
+    A function used to retrieve a unique list of items in the units inventory


~~A function used to~~ [R]etrieve[s] a unique list of items in the units inventory[.]

dedmen · 2018-03-19T12:26:15Z

How does this compare to:

In default settings aka no weapon items it should be the same. I used it in TFAR as a replacement for exactly that.

@Soldia1138

So maybe this can be a starter to offer a unique ID framework within CBA?

No. Not at all.

To the names
https://github.com/dedmen/CBA_A3/blob/b2aece723d3385e7a1d106c115ff284fecb7fb0c/addons/common/CfgFunctions.hpp#L62-L74
Also doesn't have get prefix so I leave that away.
I prefer to keep the unit. Because this doesn't work for vehicles.

Cuel · 2018-03-19T13:02:12Z

CBA_fnc_uniqueUnitItems in my humble opinion, more like a sentence.

commy2 · 2018-03-19T13:55:19Z

CBA_fnc_itemsUnique personally. Merger of items and pbUnique.

dedmen · 2018-03-19T14:34:19Z

@commy2 In the end you decide anyway. Want me to just go for your variant or want me to keep arguing that it's so ambiguous because the "unit" is missing.

commy2 · 2018-03-19T14:40:51Z

It's not "arguing", but throwing out ideas. Sadly you only have one shot and are stuck with the function name later, because bwc.

dedmen · 2018-03-19T15:18:21Z

Let's vote?
CBA_fnc_itemsUnique 😄
CBA_fnc_uniqueUnitItems 🎉
CBA_fnc_unitItemsUnique ❤️

commy2 · 2018-03-19T15:40:27Z

Since we are (hobby) programmers, we should at least use instant-runoff voting instead of this archaic method barely good enough to decide who runs a country.

commy2 · 2018-04-14T15:57:08Z

Pushed back, because #902 (comment) is still unaddressed.

dedmen · 2018-04-14T19:49:35Z

@commy2 it's supposed to replace items player. Does that return binocularMagazine?
Or do you want binocMag just for the weaponItems extra?

commy2 · 2018-04-14T20:31:35Z

addons/common/fnc_uniqueUnitItems.sqf

+        primaryWeaponMagazine _unit, secondaryWeaponMagazine _unit, handgunMagazine _unit
+     ];
+     _allItems pushBack (_unit call CBA_fnc_binocularMagazine);
+};


if (_weaponItems) then { _allItems append [ primaryWeapon _unit, secondaryWeapon _unit, handgunWeapon _unit ]; _allItems append primaryWeaponItems _unit; _allItems append secondaryWeaponItems _unit; _allItems append handgunItems _unit; _allItems append primaryWeaponMagazine _unit; _allItems append secondaryWeaponMagazine _unit; _allItems append handgunMagazine _unit; _allItems pushBack (_unit call CBA_fnc_binocularMagazine); };

Remember that primaryWeaponMagazine-no S etc. report ARRAY, exactly like the XItems versions.

commy2 · 2018-04-14T20:34:42Z

addons/common/fnc_uniqueUnitItems.sqf

+private _allItems = (assignedItems _unit);
+if (_uniform) then {_allItems append ((getItemCargo (uniformContainer _unit)) select 0);};
+if (_vest) then {_allItems append ((getItemCargo (vestContainer _unit)) select 0);};
+if (_backpack) then {_allItems append ((getItemCargo (backpackContainer _unit)) select 0);};


parenthesis aaaaa

Perfectly fine here to quickly see the order they are executed in.

aaaaa

if (_uniform) then { _allItems append (getItemCargo uniformContainer _unit select 0); }; if (_vest) then { _allItems append (getItemCargo vestContainer _unit select 0); }; if (_backpack) then { _allItems append (getItemCargo backpackContainer _unit select 0); };

T_T

getItemCargo uniformContainer _unit select 0

this is just unreadable IMO.

requested changes were made

dedmen · 2018-05-12T09:00:22Z

addons/common/fnc_uniqueUnitItems.sqf

+#include "script_component.hpp"
+SCRIPT(uniqueUnitItems);
+
+params [["_unit", objNull, [objNull]], ["_weaponItems", true, [true]], ["_backpack", true, [true]], ["_vest", true, [true]], ["_uniform", true, [true]]];


Hah!
["_weaponItems", true, [true]] default false? duh..

dedmen · 2018-05-12T09:09:02Z

Btw here is some perf data about the use-case I made this for: acemod/ACEX#114 (comment)
From 10ms to 0.2ms

Add Func

b2aece7

jonpas previously requested changes Mar 19, 2018

View reviewed changes

jonpas added the Functions label Mar 19, 2018

jonpas added this to the 3.7 milestone Mar 19, 2018

commy2 reviewed Mar 19, 2018

View reviewed changes

Rename, Indent, CfgFunctions

b5c8106

dedmen added 2 commits March 21, 2018 08:12

Rename, indent

19d9431

Description

5808da8

commy2 changed the title ~~Add getUniquePlayerItems function~~ add CBA_fnc_uniqueUnitItems Apr 14, 2018

commy2 changed the title ~~add CBA_fnc_uniqueUnitItems~~ Add CBA_fnc_uniqueUnitItems Apr 14, 2018

commy2 modified the milestones: 3.7, 3.8 Apr 14, 2018

add binoc magazine

a79f59f

commy2 reviewed Apr 14, 2018

View reviewed changes

ARRAYS

e0bdb1a

commy2 modified the milestones: 3.8, 3.7 Apr 15, 2018

commy2 approved these changes Apr 15, 2018

View reviewed changes

Killswitch00 merged commit 074c052 into CBATeam:master Apr 15, 2018

dedmen mentioned this pull request Apr 26, 2018

optimizing getRadioItems michail-nikolaev/task-force-arma-3-radio#1406

Merged

dedmen commented May 12, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CBA_fnc_uniqueUnitItems #902

Add CBA_fnc_uniqueUnitItems #902

dedmen commented Mar 19, 2018 •

edited by jonpas

Loading

Dystopian commented Mar 19, 2018

jonpas left a comment

jonpas Mar 19, 2018

dedmen Mar 19, 2018

jonpas Mar 19, 2018

jonpas Mar 19, 2018

jonpas Mar 19, 2018

jonpas commented Mar 19, 2018

Soldia1138 commented Mar 19, 2018

TheMagnetar commented Mar 19, 2018 •

edited

Loading

commy2 commented Mar 19, 2018

commy2 commented Mar 19, 2018

commy2 commented Mar 19, 2018

commy2 Mar 19, 2018

dedmen commented Mar 19, 2018 •

edited

Loading

Cuel commented Mar 19, 2018 •

edited

Loading

commy2 commented Mar 19, 2018

dedmen commented Mar 19, 2018

commy2 commented Mar 19, 2018

dedmen commented Mar 19, 2018 •

edited

Loading

commy2 commented Mar 19, 2018

commy2 commented Apr 14, 2018

dedmen commented Apr 14, 2018 •

edited

Loading

commy2 Apr 14, 2018 •

edited by jonpas

Loading

commy2 Apr 14, 2018 •

edited

Loading

commy2 Apr 14, 2018

jonpas Apr 14, 2018

commy2 Apr 14, 2018 •

edited

Loading

jonpas Apr 14, 2018

dedmen May 12, 2018 •

edited

Loading

dedmen commented May 12, 2018 •

edited

Loading

Add CBA_fnc_uniqueUnitItems #902

Add CBA_fnc_uniqueUnitItems #902

Conversation

dedmen commented Mar 19, 2018 • edited by jonpas Loading

Dystopian commented Mar 19, 2018

jonpas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonpas commented Mar 19, 2018

Soldia1138 commented Mar 19, 2018

TheMagnetar commented Mar 19, 2018 • edited Loading

commy2 commented Mar 19, 2018

commy2 commented Mar 19, 2018

commy2 commented Mar 19, 2018

Choose a reason for hiding this comment

dedmen commented Mar 19, 2018 • edited Loading

Cuel commented Mar 19, 2018 • edited Loading

commy2 commented Mar 19, 2018

dedmen commented Mar 19, 2018

commy2 commented Mar 19, 2018

dedmen commented Mar 19, 2018 • edited Loading

commy2 commented Mar 19, 2018

commy2 commented Apr 14, 2018

dedmen commented Apr 14, 2018 • edited Loading

commy2 Apr 14, 2018 • edited by jonpas Loading

Choose a reason for hiding this comment

commy2 Apr 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

commy2 Apr 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedmen May 12, 2018 • edited Loading

Choose a reason for hiding this comment

dedmen commented May 12, 2018 • edited Loading

dedmen commented Mar 19, 2018 •

edited by jonpas

Loading

TheMagnetar commented Mar 19, 2018 •

edited

Loading

dedmen commented Mar 19, 2018 •

edited

Loading

Cuel commented Mar 19, 2018 •

edited

Loading

dedmen commented Mar 19, 2018 •

edited

Loading

dedmen commented Apr 14, 2018 •

edited

Loading

commy2 Apr 14, 2018 •

edited by jonpas

Loading

commy2 Apr 14, 2018 •

edited

Loading

commy2 Apr 14, 2018 •

edited

Loading

dedmen May 12, 2018 •

edited

Loading

dedmen commented May 12, 2018 •

edited

Loading