Fix autohide glitches explainations - To make git history better #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make previous commit a bit clearer, so check commit a62b48b for actual code changes. Use _hide and _show to improve readability and keep control over transition behaviours. Only thing is, it now uses the extension's animation delay settings. Keeping the _box.hover check in an else statement guarantee other docks that do not use _onPressureSensed will keep the same behaviour. Because of this, I think setups using intellihide/autohide without the push-to-show option (most likely) will still have the bouncing glitch issue. Delete the _delayedHide value in _show instead of _animateIn since calls to said _show are ignored when the dock's state is either "shown" or "showing" and, when a delayed hide transition is queued, the dock's state is only updated AFTER the animate-in transition is completed. Replace the _hide call to _hoverChanged the same way shouldHide was (is) used in _onPressureSensed to catch any _delayedHide shenanigans by checking whether the delayed animate-out transition is still necessary instead of forcing the dock to hide right away and trigger a bounce from _box's hover-changed signals. Fixes micheleg#1232
micheleg
approved these changes
Sep 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make previous commit a bit clearer, so check commit a62b48b for
actual code changes.
Use _hide and _show to improve readability and keep control over
transition behaviours. Only thing is, it now uses the extension's
animation delay settings.
Keeping the _box.hover check in an else statement guarantee other docks
that do not use _onPressureSensed will keep the same behaviour.
Because of this, I think setups using intellihide/autohide without
the push-to-show option (most likely) will still have the bouncing
glitch issue.
Delete the _delayedHide value in _show instead of _animateIn since calls
to said _show are ignored when the dock's state is either "shown" or
"showing" and, when a delayed hide transition is queued, the dock's state
is only updated AFTER the animate-in transition is completed.
Replace the _hide call to _hoverChanged the same way shouldHide was (is)
used in _onPressureSensed to catch any _delayedHide shenanigans by checking
whether the delayed animate-out transition is still necessary instead of
forcing the dock to hide right away and trigger a bounce from _box's
hover-changed signals.
Fixes #1232