Fix/1232 again #1365
Merged
Fix/1232 again #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too many behaviour changes in the reverted commit (as correctly pointed out by the author 4b16532): 1) The hide animation is now always delayed, making it not in sync with the rest of the animations (e.g. exiting the overview) 2) Not only the dock can be shown hitting any area of the screen border, but the only way to hide is is to leave the border by the docker height even after habing entered and interacted with the dock: this is not necessary a bad behaviour, but it is un unintentional one. This reverts commit a62b48b.
The problem originates from the transition to clutter animations: 662604b and the solution for a regression due to how "queued" transitions are handled 71abe80 The solution seems to correctly removed any "delayed" hide transition. It was not canceled every time a dock show is requested, but only when a new show transition was initiated (therefore if the show is requested while the dock is already showing, the queued hide was not removed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being running this for months, time to merge this. Fix syncronization regressoin of the dock/overview transition after (#1307).