Fix inconsistent cursor movement behavior after mouse selection#3268
Merged
dmaluka merged 1 commit intomicro-editor:masterfrom Apr 25, 2024
Merged
Fix inconsistent cursor movement behavior after mouse selection#3268dmaluka merged 1 commit intomicro-editor:masterfrom
dmaluka merged 1 commit intomicro-editor:masterfrom
Conversation
Ensure that the selection start is always before the selection end, regardless of the direction of a mouse selection, to make h.Cursor.Deselect() handle its `start` argument correctly. This makes the cursor behavior after mouse selections consistent with the cursor behavior after keyboard selections. Fixes micro-editor#3055
dustdfg
approved these changes
Apr 25, 2024
JoeKar
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the selection start is always before the selection end, regardless of the direction of a mouse selection, to make
h.Cursor.Deselect()handle itsstartargument correctly.This makes the cursor behavior after mouse selections consistent with the cursor behavior after keyboard selections.
Together with @dustdfg 's fix #3091, this makes both keyboard and mouse selections work as expected. See also the discussion in #3091.
Fixes #3055