Fix SIGINT killing micro when saving with sudo#3495
Merged
JoeKar merged 2 commits intomicro-editor:masterfrom Oct 12, 2024
Merged
Fix SIGINT killing micro when saving with sudo#3495JoeKar merged 2 commits intomicro-editor:masterfrom
JoeKar merged 2 commits intomicro-editor:masterfrom
Conversation
When we are saving a file with sudo, if we interrupt sudo via Ctrl-c, it doesn't just kill sudo, it kills micro itself. The cause is the same as in the issue micro-editor#2612 for RunInteractiveShell() which was fixed by micro-editor#3357. So fix it the same way as in micro-editor#3357.
When saving a file with sudo fails (e.g. if we set `sucmd` to a non-existent binary, e.g. `set sucmd aaa`), we erroneously return success instead of the error, as a result we report to the user that that the file has been successfully saved. Fix it.
JoeKar
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are saving a file with sudo, if we interrupt sudo via
Ctrl-c, it doesn't just kill sudo, it kills micro itself.The cause is the same as the similar issue #2612 for
RunInteractiveShell()which was fixed by #3357. So fix it the same way as in #3357.Also on top of that, fix the lack of error reporting when saving with sudo fails.