Skip to content

Comments

Fix Scrollbar covering cursor#3741

Merged
JoeKar merged 1 commit intomicro-editor:masterfrom
cutelisp:sbf
May 11, 2025
Merged

Fix Scrollbar covering cursor#3741
JoeKar merged 1 commit intomicro-editor:masterfrom
cutelisp:sbf

Conversation

@cutelisp
Copy link
Contributor

@cutelisp cutelisp commented May 9, 2025

Fix #2392

By mistake I mixed commits in #3740

@dmaluka
Copy link
Collaborator

dmaluka commented May 10, 2025

Thanks for the fix. Looks good to me, but please use force-push instead of a merge commit, to avoid mess when we merge this PR.

I've also noticed a related issue: if scrollbar is disabled and then we enable it (e.g. with set scrollbar on), it may also end up covering the cursor, since Relocate() is not triggered immediately. Fix for it: #3743

@cutelisp
Copy link
Contributor Author

Thanks for the fix. Looks good to me, but please use force-push instead of a merge commit, to avoid mess when we merge this PR.

Are you referring to c85a732?
I am new to git, I don't know how I did that. Did I screwed up?

@JoeKar
Copy link
Member

JoeKar commented May 11, 2025

Are you referring to c85a732?

Yes. Most probably you merged the master into your feature branch instead of rebasing it on top of the (upstream/)master.

Did I screwed up?

Not really, but there is now a commit present, which doesn't really belong to this PR and should be removed before merging. :)

@cutelisp
Copy link
Contributor Author

Thanks, it's fixed (ig)

@JoeKar JoeKar merged commit 895d9d2 into micro-editor:master May 11, 2025
12 checks passed
theredcmdcraft pushed a commit to theredcmdcraft/micro that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrollbar covers cursor

3 participants