Skip to content

Avoid use of aspect-ratio for prominent simulator run button #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
microbit-matt-hillsdon opened this issue Nov 11, 2022 · 1 comment · Fixed by #109
Closed

Avoid use of aspect-ratio for prominent simulator run button #94

microbit-matt-hillsdon opened this issue Nov 11, 2022 · 1 comment · Fixed by #109
Assignees
@microbit-matt-hillsdon

Comments

@microbit-matt-hillsdon
Copy link
Contributor

From photos on twitter, some folks are using old enough Edge that they don't have aspect-ratio (pre v88).

We only use it for the run button and can probably avoid it so let's try that at some point.

Not urgent, it's just a flat oval and there may well be other issues with a browser that old too.
@microbit-matt-hillsdon
Copy link
Contributor Author

Also affects Safari 13.

Merged
microbit-matt-hillsdon pushed a commit that referenced this issue Feb 22, 2024
@microbit-robert
Improve support for older Safari versions (except speech) (#109)
93065b4 
- Update build workflow to use Node 20.x
- Use webkitAudioContext is AudioContext is not defined
- Use audioCtx.createBuffer in place of new AudioBuffer
- Use createBufferSource in place of new AudioBufferSourceNode
- Fix layout that relied on aspect-ratio, closes #94 

An issue with the sample rate still remains for modspeech.

Changes made to accommodate Safari 13 and 14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@microbit-matt-hillsdon microbit-matt-hillsdon

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@microbit-matt-hillsdon