-
Notifications
You must be signed in to change notification settings - Fork 10
Improve support for older Safari versions (except speech) #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview build will be at |
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We've seen Edge/Safari that are otherwise viable hit this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well except for speech. We've seen it fail on i(Pad)OS Safari <= 14.1 and pass on >= 14.5. We've not been able to test the interval.
Speech uses a 19000 sample rate that's below older Safari's 22050 minimum.
It looks like there might be some options for modspeech we could consider - I'll raise a separate issue to discuss with Damien.
An issue with the sample rate still remains for modspeech.
Changes made to accommodate Safari 13 and 14.