support long, double and boolean for tags #234

micrometer-metrics · Apr 18, 2023 · 3decdd8 · 3decdd8
1 parent dd22826
commit 3decdd8
Show file tree

Hide file tree

Showing 4 changed files with 75 additions and 0 deletions.
diff --git a/...eter-tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveSpan.java b/...eter-tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveSpan.java
@@ -104,6 +104,24 @@ public Span tag(String key, String value) {
         return this;
     }
 
+    @Override
+    public Span tag(String key, long value) {
+        this.delegate.tag(key, String.valueOf(value));
+        return this;
+    }
+
+    @Override
+    public Span tag(String key, double value) {
+        this.delegate.tag(key, String.valueOf(value));
+        return this;
+    }
+
+    @Override
+    public Span tag(String key, boolean value) {
+        this.delegate.tag(key, String.valueOf(value));
+        return this;
+    }
+
     @Override
     public Span error(Throwable throwable) {
         String message = throwable.getMessage() == null ? throwable.getClass().getSimpleName() : throwable.getMessage();

diff --git a/...rometer-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelSpan.java b/...rometer-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelSpan.java
@@ -107,6 +107,24 @@ public Span tag(String key, String value) {
         return new OtelSpan(this.delegate);
     }
 
+    @Override
+    public Span tag(String key, long value) {
+        this.delegate.setAttribute(key, value);
+        return new OtelSpan(this.delegate);
+    }
+
+    @Override
+    public Span tag(String key, double value) {
+        this.delegate.setAttribute(key, value);
+        return new OtelSpan(this.delegate);
+    }
+
+    @Override
+    public Span tag(String key, boolean value) {
+        this.delegate.setAttribute(key, value);
+        return new OtelSpan(this.delegate);
+    }
+
     @Override
     public void end(long time, TimeUnit timeUnit) {
         this.delegate.end(time, timeUnit);

diff --git a/...s/micrometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/SimpleSpan.java b/...s/micrometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/SimpleSpan.java
@@ -113,6 +113,24 @@ public SimpleSpan tag(String key, String value) {
         return this;
     }
 
+    @Override
+    public Span tag(String key, long value) {
+        this.tags.put(key, String.valueOf(value));
+        return this;
+    }
+
+    @Override
+    public Span tag(String key, double value) {
+        this.tags.put(key, String.valueOf(value));
+        return this;
+    }
+
+    @Override
+    public Span tag(String key, boolean value) {
+        this.tags.put(key, String.valueOf(value));
+        return this;
+    }
+
     @Override
     public SimpleSpan error(Throwable throwable) {
         this.throwable = throwable;

diff --git a/micrometer-tracing/src/main/java/io/micrometer/tracing/Span.java b/micrometer-tracing/src/main/java/io/micrometer/tracing/Span.java
@@ -71,6 +71,21 @@ public Span tag(String key, String value) {
             return this;
         }
 
+        @Override
+        public Span tag(String key, long value) {
+            return this;
+        }
+
+        @Override
+        public Span tag(String key, double value) {
+            return this;
+        }
+
+        @Override
+        public Span tag(String key, boolean value) {
+            return this;
+        }
+
         @Override
         public Span error(Throwable throwable) {
             return this;
@@ -151,6 +166,12 @@ public Span remoteIpAndPort(String ip, int port) {
      */
     Span tag(String key, String value);
 
+    Span tag(String key, long value);
+
+    Span tag(String key, double value);
+
+    Span tag(String key, boolean value);
+
     /**
      * Records an exception for this span.
      * @param throwable to record