Update to 4.4.2 #1459
Merged
Update to 4.4.2 #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is with Maven and Groovy... I believe it's caused by micronaut-projects/micronaut-tracing#559 which was in 6.5.2 of micronaut-tracing, but I'm not currently sure why |
When also using the internal Micronaut-Gradle-Enterprise plugin
until we have a fix for core-processor not being on the compile classpath
|
So previously we had the core processor as an api dependency, so it was a compile dependency when we pulled in the parent Now it's coming through as I guess we need fix starter to add it as a compile dependency when using jaeger, groovy and maven |
until we have a fix for core-processor not being on the compile classpath
timyates
reviewed
May 7, 2024
| @@ -4,6 +4,7 @@ | |||
| "authors": ["Sergio del Amo"], | |||
| "tags": ["distributed-tracing", "zipkin", "validation"], | |||
| "categories": ["Distributed Tracing"], | |||
| "skips": [["maven", "groovy"]], | |||
There was a problem hiding this comment.
Added a method to skip a given buildtool and language combination
Here currently Maven and Groovy doesn't work, but instead of skipping all maven, or all groovy, we can just skip maven + groovy
sdelamo
pushed a commit
that referenced
this pull request
May 13, 2024
AndreaLaGrotteria
pushed a commit
to AndreaLaGrotteria/micronaut-guides
that referenced
this pull request
Oct 3, 2024
AndreaLaGrotteria
pushed a commit
to AndreaLaGrotteria/micronaut-guides
that referenced
this pull request
Oct 3, 2024
In micronaut-projects#1459 we added the ability to totally skip a build tool/language. This broke guides which are generated but their tests are skipped (as they require resource we don't have on CI). Fixes micronaut-projects#1462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.