-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 4.4.2 #1459
Update to 4.4.2 #1459
Conversation
The failure is with Maven and Groovy... I believe it's caused by micronaut-projects/micronaut-tracing#559 which was in 6.5.2 of micronaut-tracing, but I'm not currently sure why |
When also using the internal Micronaut-Gradle-Enterprise plugin
until we have a fix for core-processor not being on the compile classpath
So previously we had the core processor as an api dependency, so it was a compile dependency when we pulled in the parent Now it's coming through as I guess we need fix starter to add it as a compile dependency when using jaeger, groovy and maven |
until we have a fix for core-processor not being on the compile classpath
@@ -4,6 +4,7 @@ | |||
"authors": ["Sergio del Amo"], | |||
"tags": ["distributed-tracing", "zipkin", "validation"], | |||
"categories": ["Distributed Tracing"], | |||
"skips": [["maven", "groovy"]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a method to skip a given buildtool and language combination
Here currently Maven and Groovy doesn't work, but instead of skipping all maven, or all groovy, we can just skip maven + groovy
In micronaut-projects#1459 we added the ability to totally skip a build tool/language. This broke guides which are generated but their tests are skipped (as they require resource we don't have on CI). Fixes micronaut-projects#1462
No description provided.