fix: Remove core processor from the mn opentelemetry http library #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #553 The Micronaut OpenTelemetry Http plugin was exposing an API dependency on the processor classes. This in turn pulled in 7Mb of unrequired dependencies. This PR fixes this issue, and does a tiny bit of cleanup. In general, this module seems to have an excessive use of `api` for dependencies. But I don't think we can do much more without causing downstream breakages. I ran the guide mentioned in the issue, and then re-ran it with a snapshot version of this PR, the following Build Scans were the result: `bookcatalog` - before https://ge.micronaut.io/s/ofkuix744eine - after https://ge.micronaut.io/s/s6wap7cgohfzs `bookinventory` - before https://ge.micronaut.io/s/vokg7vtiyhztg - after https://ge.micronaut.io/s/67p35n6pkovce `bookrecommendation` - before https://ge.micronaut.io/s/6ozkmgcfwtgb4 - after https://ge.micronaut.io/s/i3hi5u2iwgjzs
timyates
added
type: bug
|
sdelamo
reviewed
May 3, 2024
sdelamo
approved these changes
May 3, 2024
n0tl3ss
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553
The Micronaut OpenTelemetry Http plugin was exposing an API dependency on the processor classes. This in turn pulled in 7Mb of unrequired dependencies.
This PR fixes this issue, and does a tiny bit of cleanup.
In general, this module seems to have an excessive use of
apifor dependencies. But I don't think we can do much more without causing downstream breakages.I ran the guide mentioned in the issue, and then re-ran it with a snapshot version of this PR, the following Build Scans were the result:
bookcatalogbookinventorybookrecommendation