Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove core processor from the mn opentelemetry http library #559

Merged
merged 2 commits into from
May 3, 2024
Merged

fix: Remove core processor from the mn opentelemetry http library #559

merged 2 commits into from
May 3, 2024

Commits on May 2, 2024

  1. fix: Remove core processor from the mn opentelemetry http library 

    Closes #553

The Micronaut OpenTelemetry Http plugin was exposing an API dependency on the processor classes.
This in turn pulled in 7Mb of unrequired dependencies.

This PR fixes this issue, and does a tiny bit of cleanup.

In general, this module seems to have an excessive use of `api` for dependencies.
But I don't think we can do much more without causing downstream breakages.

I ran the guide mentioned in the issue, and then re-ran it with a snapshot version of this PR, the following Build Scans were the result:

`bookcatalog`
- before https://ge.micronaut.io/s/ofkuix744eine
- after https://ge.micronaut.io/s/s6wap7cgohfzs

`bookinventory`
- before https://ge.micronaut.io/s/vokg7vtiyhztg
- after https://ge.micronaut.io/s/67p35n6pkovce

`bookrecommendation`
- before https://ge.micronaut.io/s/6ozkmgcfwtgb4
- after https://ge.micronaut.io/s/i3hi5u2iwgjzs
    @timyates
    timyates committed May 2, 2024
    Configuration menu
    Copy the full SHA
    078d316 View commit details
    Browse the repository at this point in the history

  2. Fix the obvious mistake

    @timyates
    timyates committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cc962fc View commit details
    Browse the repository at this point in the history